-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-check for 1.16.0 that supports C++20 #275
Conversation
…nda-forge-pinning 2025.02.07.19.05.24
Revert "Apply cpp20 fixes from Xanthos to nightly build" This reverts commit 9462dca.
4464e4b
to
bad3736
Compare
I had to manually remove the |
@jdblischak thank you -- this is fabulous!!! TBD whether our next will be 1.15.8 or 1.16.0 -- requiring C++ 20 and GCC 13 is perhaps a "big enough change" to merit a 1.16.0. Let's keep this PR open for a bit until we decide what to call the next release, and when. |
@jdblischak I used |
All green! Closing as per our established procedure. |
I am also testing |
As expected, this worked:
@johnkerl please include |
Here is the pre-check PR for the future SOMA release that will support C++20. I followed my instructions in #246 (comment) to create the PR.
@johnkerl once you have a candidate release ready to pre-check, we just need to update
git_rev
to point to that commit. You can either push directly to my branch (it's from my fork, so you'd have to add my fork as a remote), or you can simply share the SHA here and I can update the PR.#3720 [sc-63626]