Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page Scale: add pageSize KEEP #1798 #1800

Merged
merged 9 commits into from
Sep 8, 2024
Merged

Page Scale: add pageSize KEEP #1798 #1800

merged 9 commits into from
Sep 8, 2024

Conversation

nachokb
Copy link
Contributor

@nachokb nachokb commented Sep 5, 2024 •
edited
Loading

Description

Add KEEP value to pageSize argument which allows page scale to keep the source file's page size.

Closes #1798

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@github-actions github-actions bot added Java Pull requests that update Java code Front End Issues or pull requests related to front-end development Translation API API-related issues or pull requests labels Sep 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024 •
edited
Loading

🚀 Translation Verification Summary

📋 Checking with the file messages_en_GB.properties from the pr-branch - Checking the pr-branch

🗂️ Checking File: messages_ar_AR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_bg_BG.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ca_CA.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_cs_CZ.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_da_DK.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_de_DE.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_el_GR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_en_US.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_es_ES.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_eu_ES.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_fr_FR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ga_IE.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_hi_IN.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_hr_HR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_hu_HU.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_id_ID.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_it_IT.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ja_JP.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ko_KR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_nl_NL.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_no_NB.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_pl_PL.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_pt_BR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_pt_PT.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ro_RO.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ru_RU.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_sk_SK.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_sr_LATN_RS.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_sv_SE.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_th_TH.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_tr_TR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_uk_UA.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_vi_VN.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_zh_CN.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_zh_TW.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

✅ Overall Check Status: Success

@nachokb nachokb changed the title Page Scale: add page size keep #1798 Page Scale: add page size KEEP #1798 Sep 5, 2024
@nachokb nachokb changed the title Page Scale: add page size KEEP #1798 Page Scale: add pageSize KEEP #1798 Sep 5, 2024
@nachokb nachokb marked this pull request as ready for review September 5, 2024 05:46
@nachokb nachokb requested a review from Frooodle as a code owner September 5, 2024 05:46
@nachokb
Merge branch 'main' into page-scale--add-page-size-keep--1798
b81e640 
* main:
  📝 Update README: Translation Progress Table (Stirling-Tools#1816)
  Update messages_da_DK.properties
  Update messages_da_DK.properties
  Update messages_it_IT.properties (Stirling-Tools#1815)
  test (Stirling-Tools#1814)
  📝 Update README: Translation Progress Table (Stirling-Tools#1813)
  Update translation files (Stirling-Tools#1812)
  Added functionality to set font size and font type in both frontend and backend. (Stirling-Tools#1783)
  Fix insertFileButton referencing the old addPdfs method. (Stirling-Tools#1809)
  📝 Update README: Translation Progress Table (Stirling-Tools#1806)
  Language change contribution (Hindi) (Stirling-Tools#1799)
  Add info translation (Stirling-Tools#1791)
@nachokb
PR feedback: make caption shorter, avoid unnecessary verbosity (Stirl…
b1103b2 
…ing-Tools#1798)
@nachokb nachokb force-pushed the page-scale--add-page-size-keep--1798 branch from 616ed14 to b1103b2 Compare September 6, 2024 05:05
@nachokb nachokb requested a review from Frooodle September 6, 2024 05:05
@Frooodle Frooodle merged commit 5803131 into Stirling-Tools:main Sep 8, 2024
7 checks passed
@Frooodle
Copy link
Member

Frooodle commented Sep 8, 2024

Awesome work :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frooodle Frooodle Frooodle approved these changes

Assignees
No one assigned
Labels
API API-related issues or pull requests Front End Issues or pull requests related to front-end development Java Pull requests that update Java code Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add "Keep source file Page Size" to Ajust Page Scale
2 participants
@nachokb @Frooodle