Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality to set font size and font type in both frontend and backend. #1783

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

creator1999
Copy link
Contributor

Added functionality to set font size and font type in both frontend and backend, currently supported for only 3 font types.
#1768

@creator1999 creator1999 requested a review from Frooodle as a code owner August 31, 2024 18:33
@github-actions github-actions bot added Java Pull requests that update Java code Front End Issues or pull requests related to front-end development Back End Issues related to back-end development Translation Security Security-related issues or pull requests API API-related issues or pull requests labels Aug 31, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

🚀 Translation Verification Summary

📋 Checking with the file messages_en_GB.properties from the pr-branch - Checking the pr-branch

🗂️ Checking File: messages_en_US.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

✅ Overall Check Status: Success

@@ -3,7 +3,8 @@
###########
# the direction that the language is written (ltr=left to right, rtl = right to left)
language.direction=ltr

addPageNumbers.fontSize=Font Size
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to GB file as well!


float font_size = request.getFontSize();
String font_type = request.getFontType();
System.out.println(request.toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove print statement

@creator1999
Copy link
Contributor Author

@Frooodle suggested changes has been made as per comment please review.

@Frooodle Frooodle merged commit c650a76 into Stirling-Tools:main Sep 5, 2024
7 checks passed
nachokb added a commit to nachokb/Stirling-PDF that referenced this pull request Sep 6, 2024
* main:
  📝 Update README: Translation Progress Table (Stirling-Tools#1816)
  Update messages_da_DK.properties
  Update messages_da_DK.properties
  Update messages_it_IT.properties (Stirling-Tools#1815)
  test (Stirling-Tools#1814)
  📝 Update README: Translation Progress Table (Stirling-Tools#1813)
  Update translation files (Stirling-Tools#1812)
  Added functionality to set font size and font type in both frontend and backend. (Stirling-Tools#1783)
  Fix insertFileButton referencing the old addPdfs method. (Stirling-Tools#1809)
  📝 Update README: Translation Progress Table (Stirling-Tools#1806)
  Language change contribution (Hindi) (Stirling-Tools#1799)
  Add info translation (Stirling-Tools#1791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API-related issues or pull requests Back End Issues related to back-end development Front End Issues or pull requests related to front-end development Java Pull requests that update Java code Security Security-related issues or pull requests Translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants