-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality to set font size and font type in both frontend and backend. #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Translation Verification Summary📋 Checking with the file
|
Frooodle
requested changes
Sep 4, 2024
@@ -3,7 +3,8 @@ | |||
########### | |||
# the direction that the language is written (ltr=left to right, rtl = right to left) | |||
language.direction=ltr | |||
|
|||
addPageNumbers.fontSize=Font Size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add to GB file as well!
|
||
float font_size = request.getFontSize(); | ||
String font_type = request.getFontType(); | ||
System.out.println(request.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove print statement
@Frooodle suggested changes has been made as per comment please review. |
nachokb
added a commit
to nachokb/Stirling-PDF
that referenced
this pull request
Sep 6, 2024
* main: 📝 Update README: Translation Progress Table (Stirling-Tools#1816) Update messages_da_DK.properties Update messages_da_DK.properties Update messages_it_IT.properties (Stirling-Tools#1815) test (Stirling-Tools#1814) 📝 Update README: Translation Progress Table (Stirling-Tools#1813) Update translation files (Stirling-Tools#1812) Added functionality to set font size and font type in both frontend and backend. (Stirling-Tools#1783) Fix insertFileButton referencing the old addPdfs method. (Stirling-Tools#1809) 📝 Update README: Translation Progress Table (Stirling-Tools#1806) Language change contribution (Hindi) (Stirling-Tools#1799) Add info translation (Stirling-Tools#1791)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to set font size and font type in both frontend and backend, currently supported for only 3 font types.
#1768