Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insertFileButton referencing the old addPdfs method. #1809

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

FiratUsta
Copy link
Contributor

Description

Fixes insertFileButton inside pages-container in multi-tools. It used to reference the old addPdfs method, thus not working.

Closes #1807

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

@FiratUsta FiratUsta requested a review from Frooodle as a code owner September 5, 2024 13:35
@github-actions github-actions bot added the Front End Issues or pull requests related to front-end development label Sep 5, 2024
@Frooodle Frooodle merged commit d5b0f1f into Stirling-Tools:main Sep 5, 2024
2 checks passed
@Frooodle
Copy link
Member

Frooodle commented Sep 5, 2024

Greatly appreciated! thanks

@FiratUsta FiratUsta deleted the fix-insert branch September 5, 2024 15:05
nachokb added a commit to nachokb/Stirling-PDF that referenced this pull request Sep 6, 2024
* main:
  📝 Update README: Translation Progress Table (Stirling-Tools#1816)
  Update messages_da_DK.properties
  Update messages_da_DK.properties
  Update messages_it_IT.properties (Stirling-Tools#1815)
  test (Stirling-Tools#1814)
  📝 Update README: Translation Progress Table (Stirling-Tools#1813)
  Update translation files (Stirling-Tools#1812)
  Added functionality to set font size and font type in both frontend and backend. (Stirling-Tools#1783)
  Fix insertFileButton referencing the old addPdfs method. (Stirling-Tools#1809)
  📝 Update README: Translation Progress Table (Stirling-Tools#1806)
  Language change contribution (Hindi) (Stirling-Tools#1799)
  Add info translation (Stirling-Tools#1791)
dingyang666 pushed a commit to njtech-latex/Stirling-PDF that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Front End Issues or pull requests related to front-end development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Multi-tools File Insertion Between Pages Won't Work
2 participants