Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add "Keep source file Page Size" to Ajust Page Scale #1798

Closed
1 task done
nachokb opened this issue Sep 5, 2024 · 1 comment · Fixed by #1800
Closed
1 task done

[Feature Request]: Add "Keep source file Page Size" to Ajust Page Scale #1798

nachokb opened this issue Sep 5, 2024 · 1 comment · Fixed by #1800
Labels
enhancement New feature or request

Comments

@nachokb
Copy link
Contributor

nachokb commented Sep 5, 2024

Feature Description

The adjust page-scale command requires the user to specify a Page Size. There needs to be a way to leave the page as is but scale its content.

Why is this feature valuable?

I happened to need a way to just scale down the content a bit while leaving the page intact without the need to know anything about it previously.

This idea met a good reception in the project's Discord.

Suggested Implementation

Add an option "Keep source file Page Size" to the pageSize attribute;

ScalePagesController needs to be aware of this option, and treat it accordingly;

This will need a first step to read the dimensions and use those as targetSize;

Additional Information

Other implementations:

  • pdfScale: supports this use case;
  • could not find another one;

(pdftk and others do not support scaling content)

No Duplicate of the Feature

  • I have verified that there are no existing features requests similar to my request.
@nachokb nachokb added the enhancement New feature or request label Sep 5, 2024
@nachokb
Copy link
Contributor Author

nachokb commented Sep 5, 2024

I'm working on this.

nachokb added a commit to nachokb/Stirling-PDF that referenced this issue Sep 5, 2024
nachokb added a commit to nachokb/Stirling-PDF that referenced this issue Sep 5, 2024
nachokb added a commit to nachokb/Stirling-PDF that referenced this issue Sep 5, 2024
Frooodle added a commit that referenced this issue Sep 8, 2024
* add `scalePages.keepPageSize` i18n key (#1798)

* add KEEP option to frontend (#1798)

* extract ScalePagesController.getTargetSize() (#1798)

* make ScalePageController honor `pageSize` value `KEEP`

* PR feedback: make caption shorter, avoid unnecessary verbosity (#1798)

* Update messages_ar_AR.properties

---------

Co-authored-by: Anthony Stirling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant