Introduce critical time and handler time metrics #7095

SzymonPobiega · 2024-07-05T12:54:06Z

The implementation takes advantage of IMeterFactory that is available in the DI container.

Replaces

Documentation PR Particular/docs.particular.net#6724

Documentation

…ied an increase in the version, that still remains 0.x since the whole metrics module is in experimental state.

…t is shorter and so cheaper.

…- this change was initially required by the code in HandlingMetricsFactory.

Fix failing tests.

…re explicit.

…rity.

…7059) * Use seconds instead of milliseconds to record message handling time * Fix Approved API

This reverts commit 4b25647.

…implementation.

… pipeline metrics.

…provider of IIncomingPipelineMetrics with the interface.

src/NServiceBus.AcceptanceTests/Core/OpenTelemetry/Metrics/TestingMetricListener.cs

saratry and others added 30 commits July 3, 2024 14:30

Register handling time metrics.

0144baf

The API has been updated, and accordingly the approved txt. This impl…

c87fbb8

…ied an increase in the version, that still remains 0.x since the whole metrics module is in experimental state.

Add missing documentation for return value.

2882157

Newly introduced classes and interfaces should not be public.

9c88d39

For tags, replace the complete Type descriptor with the FullName, tha…

a52abb8

…t is shorter and so cheaper.

Exclusion of generated internal struct from the Namespace validation …

6822589

…- this change was initially required by the code in HandlingMetricsFactory.

Tests massage handling time metrics.

63df3f8

Introduce new unit test for metrics' name validation.

c88b47e

Fix failing tests.

Fix metrics unit test.

2611b84

Tests improvements.

8b26cb4

Add discriminator Tag to handling metrics.

a7a886f

Refactor the code to avoid auto-generated structure.

b8bfc04

Tests improvement.

ab733a6

Fix typo.

e38cfb5

Make tags field readonly.

2169aa9

Fix note description.

51de44d

Use var instead of explicit type.

2ddf602

Rename HandlingMetrics... types to MessageHandlingMetrics... to be mo…

ffc739b

…re explicit.

Rename HandlingMetrics... types to MessageHandlingMetrics... to be mo…

19f5c8b

…re explicit.

Make the TagList not readonly to allow to add the FailureType tag.

a19728f

Rename HandlingTime to MessageHandlerTime for clarity.

1d3b2a0

API test improvement to check the metric name and type mapping.

b1b4e49

Rename the static method that provides the common metric tags for cla…

648c5ed

…rity.

Test improvement to remove the field name from API verification.

e914775

Validate also the metric unit since they are part of the API.

f2cedb8

Use seconds instead of milliseconds to record message handling time (#…

950d202

…7059) * Use seconds instead of milliseconds to record message handling time * Fix Approved API

Pull request remarks.

6b7914c

Add missing usings

b26f0f6

Use collection expressions

52b68f1

Revert "Use collection expressions"

b898467

This reverts commit 4b25647.

SzymonPobiega and others added 7 commits July 4, 2024 13:06

Fix the acceptance tests

5c21be4

Define IIncomingPipelineMetrics interface to allow the usage of NoOp …

e5b94d6

…implementation.

Fix MainPipelineExecutorTests using No Op implementation for incoming…

ee5a050

… pipeline metrics.

Change NoOpIncomingPipelineMetrics namespace to NServiceBus

764481f

Mark IncomingPipelineMetrics as a required Singleton component in DI.

c63cdfb

Simplify the constructor of InvokeHandlerTerminator by replacing the …

5b011a1

…provider of IIncomingPipelineMetrics with the interface.

Fix existing tests.

aa4230b

SzymonPobiega assigned SzymonPobiega and saratry Jul 5, 2024

SzymonPobiega added 3 commits July 6, 2024 15:48

Fix the build

abfa21f

Fix inspection

81ede72

Fix inspection

e3e158b

SzymonPobiega marked this pull request as ready for review July 7, 2024 20:46

SzymonPobiega requested a review from saratry July 8, 2024 06:52

Replace failure type tag with error type tag.

c73f9e0

saratry approved these changes Jul 8, 2024

View reviewed changes

SzymonPobiega changed the title ~~Add critical time, processing time and handler time metrics~~ Add critical time, handler time and handler time metrics Jul 8, 2024

SzymonPobiega changed the title ~~Add critical time, handler time and handler time metrics~~ Add critical time and handler time metrics using IMeterFactory-in-DI approach Jul 8, 2024

SzymonPobiega merged commit 1014092 into master Jul 8, 2024
3 checks passed

This was referenced Jul 18, 2024

Adjust documentation for OpenTelemetry changes in NServiceBus 9.1 Particular/docs.particular.net#6718

Merged

Emit message handler time metric #7048

Closed

Use the IMeterFactory approach #7087

Closed

Emit critical time metric #7058

Closed

SzymonPobiega added this to the 9.1.0 milestone Jul 18, 2024

SzymonPobiega added the Feature label Jul 18, 2024

mauroservienti deleted the meter-factory branch July 18, 2024 12:57

SzymonPobiega mentioned this pull request Jul 19, 2024

Add processing times to OpenTelemetry metrics #6868

Closed

SzymonPobiega changed the title ~~Add critical time and handler time metrics using IMeterFactory-in-DI approach~~ Introduce critical time and handler time metrics Jul 19, 2024

bbrandt reviewed Jul 24, 2024

View reviewed changes

src/NServiceBus.AcceptanceTests/Core/OpenTelemetry/Metrics/TestingMetricListener.cs Show resolved Hide resolved

Kielek mentioned this pull request Sep 5, 2024

NServiceBus - metrics support 9.1.0+ open-telemetry/opentelemetry-dotnet-instrumentation#3607

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce critical time and handler time metrics #7095

Introduce critical time and handler time metrics #7095

SzymonPobiega commented Jul 5, 2024 •

edited by saratry

Loading

Introduce critical time and handler time metrics #7095

Introduce critical time and handler time metrics #7095

Conversation

SzymonPobiega commented Jul 5, 2024 • edited by saratry Loading

SzymonPobiega commented Jul 5, 2024 •

edited by saratry

Loading