Use the IMeterFactory approach #7087
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n receiving a message (#7079) * Moves metrics and traces tests in dedicated folders for clarity * Adds an extension to publish and send options to start a new trace when receiving the published or sent message * add xmldocs * approval file * move * rename, and then dots and spaces, because they matter! * approval files * Change the default behavior for publishes to always break the trace Provide an API to continue the trace Use a feature with behaviors to control this behavior * Move the start/continue trace tests to files based on message operation (send/publish) * Approve API changes * Fix a test * this is handled in the publish behavior instead * revert test change --------- Co-authored-by: SzymonPobiega <[email protected]>
src/NServiceBus.Core/OpenTelemetry/Metrics/MessagingMetricsMeters.cs
Outdated
Show resolved
Hide resolved
|
|
||
| class MessagingMetricsMeters | ||
| { | ||
| public MessagingMetricsMeters(IMeterFactory meterFactory) |
There was a problem hiding this comment.
If we keep this approach can we rename this to MessagingMetrics? Or MessagingMeters? I don't have a strong preference as long as it doesn't combine both namings
…taRegistry (#7086) * Extract old implementation with tests that fail * New implementation that passes the tests * Use the new parser * Root namespace * Simplify used types * And now without spelling errors * Array edge cases to verify whether the parsing is robust enough --------- Co-authored-by: danielmarbach <[email protected]>
…endpoint name tags (#7071) Add specific meters for recoverability actions with message type and endpoint name tags Co-authored-by: Laila Bougria <[email protected]>
mauroservienti
commented
Jun 27, 2024
Comment on lines
18
to
19
| string queueNameBase, | ||
| string endpointDiscriminator) |
There was a problem hiding this comment.
These two parameters sound off. They are needed down below to initialize default tags in the IncomingPipelineMetricTags, but still 🤷
…e Interfaces (#7081) * Add a test to verify the messages referencing core are scanned * Failing test for messages that reference message interfaces * Unify in one test due avoid assembly loading issues * Cleanup * AssemblyScanner should scan assemblies that reference the message interfaces assembly to make sure messages using those interfaces can be discovered and do not act like unobtrusive messages * Extract into method with a huge comment and inline hints * Add a type forwarding test as a safety net * Update src/NServiceBus.Core.Tests/AssemblyScanner/When_using_type_forwarding.cs Co-authored-by: Phil Bastian <[email protected]> * Apply suggestions from code review Co-authored-by: Brandon Ording <[email protected]> * string.Equals Co-authored-by: Brandon Ording <[email protected]> --------- Co-authored-by: danielmarbach <[email protected]> Co-authored-by: Phil Bastian <[email protected]> Co-authored-by: Brandon Ording <[email protected]>
Co-authored-by: Daniel Marbach <[email protected]>
…ied an increase in the version, that still remains 0.x since the whole metrics module is in experimental state.
…t is shorter and so cheaper.
…- this change was initially required by the code in HandlingMetricsFactory.
Fix failing tests.
…e by feature pattern for Metrics This allows removing metrics dedicated features
…discriminator info
SzymonPobiega
force-pushed
the
meter-factory
branch
from
5f93b31 to
2caf40b
Compare
… pipeline metrics.
…provider of IIncomingPipelineMetrics with the interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.