Emit critical time metric #7058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBoike
reviewed
Jun 11, 2024
src/NServiceBus.Core/OpenTelemetry/Metrics/MetricsExtensions.cs
Outdated
Show resolved
Hide resolved
mauroservienti
force-pushed
the
otel/handling-metrics
branch
from
d1df89e to
829b70e
Compare
mauroservienti
force-pushed
the
otel/critical-time
branch
from
ff57dd7 to
bd2cb97
Compare
mauroservienti
changed the title
This was referenced Jun 20, 2024
DavidBoike
reviewed
Jun 20, 2024
src/NServiceBus.Core/OpenTelemetry/Metrics/CriticalTimeMetrics.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.Core/OpenTelemetry/Metrics/MetricsExtensions.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.Core/OpenTelemetry/Metrics/MetricsExtensions.cs
Outdated
Show resolved
Hide resolved
|
Reverting to draft to signal the dependency on #7077 and preventing accidental merge |
mauroservienti
force-pushed
the
otel/handling-metrics
branch
from
1b9dc91 to
53eb461
Compare
Use Dictionary i.o. IReadOnlyDictionary for performance.
…to prevent adding unwanted tags everywhere in the future.
mauroservienti
force-pushed
the
otel/critical-time
branch
from
aedfe04 to
8ebd3e1
Compare
|
@lailabougria @SzymonPobiega, this is ready for a review |
lailabougria
approved these changes
Jun 25, 2024
src/NServiceBus.AcceptanceTests/Core/OpenTelemetry/When_incoming_message_handled.cs
Show resolved
Hide resolved
| @@ -19,4 +19,7 @@ class Meters | |||
|
|
|||
| internal static readonly Histogram<double> MessageHandlerTime = | |||
| NServiceBusMeter.CreateHistogram<double>(Metrics.MessageHandlerTime, "s", "The time in seconds for the execution of the business code."); | |||
|
|
|||
| internal static readonly Histogram<double> CriticalTime = | |||
| NServiceBusMeter.CreateHistogram<double>(Metrics.CriticalTime, "s", "The time in seconds between when the message was sent until processed by the endpoint."); | |||
There was a problem hiding this comment.
Suggested change
| NServiceBusMeter.CreateHistogram<double>(Metrics.CriticalTime, "s", "The time in seconds between when the message was sent until processed by the endpoint."); | |
| NServiceBusMeter.CreateHistogram<double>(Metrics.CriticalTime, "s", "The time in seconds from when the message was sent to when it was processed."); |
There was a problem hiding this comment.
I'm fine either way. The documentation states the following:
The time between when a message is sent and when it is fully processed.
Shall we align the text here with docs?
Suggested change
| NServiceBusMeter.CreateHistogram<double>(Metrics.CriticalTime, "s", "The time in seconds between when the message was sent until processed by the endpoint."); | |
| NServiceBusMeter.CreateHistogram<double>(Metrics.CriticalTime, "s", "The time in seconds between when a message is sent and when it is fully processed."); |
Comment on lines
+73
to
+76
| incomingPipelineMetricTags.ApplyTags(ref tags, [ | ||
| MeterTags.QueueName, | ||
| MeterTags.EndpointDiscriminator, | ||
| MeterTags.MessageType]); |
There was a problem hiding this comment.
@lailabougria @SzymonPobiega, is it useful to add here the MeterTags.MessageHandlerTypes? It'll be published to both critical and processing time, reporting all the handlers involved.
Suggested change
| incomingPipelineMetricTags.ApplyTags(ref tags, [ | |
| MeterTags.QueueName, | |
| MeterTags.EndpointDiscriminator, | |
| MeterTags.MessageType]); | |
| incomingPipelineMetricTags.ApplyTags(ref tags, [ | |
| MeterTags.QueueName, | |
| MeterTags.EndpointDiscriminator, | |
| MeterTags.MessageType, | |
| MeterTags.MessageHandlerTypes]); |
Comment on lines
+50
to
+55
| [Test] | ||
| public async Task Should_not_record_critical_time_on_failure() | ||
| { | ||
| using TestingMetricListener metricsListener = await WhenMessagesHandled(() => new MyExceptionalMessage()); | ||
| metricsListener.AssertMetric(CriticalTimeMetricName, 0); | ||
| } |
There was a problem hiding this comment.
@lailabougria, what do you think about this test? If that's what you meant, I'll add a similar one to the processing time metric PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new OpenTelemetry-native metric for measuring the message's critical time.
POA: