Document the new 9.1 OpenTelemetry meters #6719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauroservienti
requested review from
SzymonPobiega,
DavidBoike,
saratry and
lailabougria
mauroservienti
commented
Jun 25, 2024
nservicebus/operations/opentelemetry_content_core_[8,).partial.md
Outdated
Show resolved
Hide resolved
Closed
|
The failure is expected, there isn't a 9.1 NServiceBus version on NuGet yet |
DavidBoike
approved these changes
Jun 25, 2024
| #### Example | ||
|
|
||
| ```c# |
There was a problem hiding this comment.
Make legit snippet? (Not sure if this would be an 8 and 9 snippet or a 9.1 only snippet)
| Enable OpenTelemetry instrumentation in NServiceBus: |
There was a problem hiding this comment.
Why was this inlined? I just split this up further in another PR that conflicts with this change, so we'll have to coordinate on which structure to keep. Given what I've added now in the tracing section, I think it's getting large enough to benefit from splitting up. See #6718
There was a problem hiding this comment.
Laila, go ahead with that PR. Once that's merged, I'll rebase (or maybe even recreate) this one to align with those larger changes. No worries.
Co-authored-by: David Boike <[email protected]>
Co-authored-by: David Boike <[email protected]>
Co-authored-by: Laila Bougria <[email protected]>
|
Closing in favor of #6724 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for: