Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust documentation for OpenTelemetry changes in NServiceBus 9.1 #6718

Merged
merged 23 commits into from
Jul 19, 2024
Merged

Adjust documentation for OpenTelemetry changes in NServiceBus 9.1 #6718

merged 23 commits into from
Jul 19, 2024

Conversation

lailabougria
Copy link
Contributor

@lailabougria lailabougria commented Jun 25, 2024 •
edited by SzymonPobiega
Loading

This PR provides documentation for:

  • The default spans that are created, and whether they are children to the originating context or new traces that link to the origination context
  • APIs to deviate from the default behavior
  • New metrics

@lailabougria lailabougria changed the title Allow APIs to break and continue trace OpenTelemetry: Allow APIs to break and continue trace Jun 26, 2024
@lailabougria lailabougria mentioned this pull request Jun 26, 2024
Closed
@SzymonPobiega SzymonPobiega mentioned this pull request Jun 27, 2024
Merged
@lailabougria lailabougria changed the title OpenTelemetry: Allow APIs to break and continue trace OpenTelemetry: Document span structure for send/publish and delayed messages Jun 27, 2024
This was referenced Jun 27, 2024
Closed
Closed
@lailabougria
Copy link
Contributor Author

@DavidBoike I can't spot anything odd in this link and can't figure out why it doesn't work. Can you see what I'm missing?

@SzymonPobiega SzymonPobiega force-pushed the break-continue-trace branch from 7121720 to 9c8ea5d Compare July 15, 2024 09:59
@SzymonPobiega SzymonPobiega changed the title OpenTelemetry: Document span structure for send/publish and delayed messages Adjust documentation for OpenTelemetry changes in NServiceBus 9.1 Jul 18, 2024
lailabougria and others added 17 commits July 19, 2024 10:51
@lailabougria @SzymonPobiega
restructure otel docs per signal
f9d97ff
@lailabougria @SzymonPobiega
add span structure
cd2c468
@lailabougria @SzymonPobiega
adds snippets for new apis
77b4a80
@lailabougria @SzymonPobiega
split snippet and fix name
702daab
@lailabougria @SzymonPobiega
fix naming in graphs
51126e3
@SzymonPobiega
Fixed version ranges
ba31c7e
@SzymonPobiega
Add snippets folder for 9.1
95134e8
@lailabougria @SzymonPobiega
document that delayed messages are always linked
d427a93
@lailabougria @SzymonPobiega
fix link
64bfa1e
@lailabougria @SzymonPobiega
rename to metrics to match the otel signal
36875a1
@SzymonPobiega
Fix the build
1dad406
@mauroservienti @SzymonPobiega
Document the new 9.1 OpenTelemetry meters
f0fed6b 
Update processing time definition

Fix formatting

Make the partial specific

Add empty Core 9.1 snippets

Apply suggestions from code review

Co-authored-by: David Boike <[email protected]>

Update Snippets/Core/Core_9.1/Core_9.1.csproj

Co-authored-by: David Boike <[email protected]>

Update monitoring/metrics/definitions.md

Co-authored-by: Laila Bougria <[email protected]>

Split the files back
@SzymonPobiega
Replace meters partials with metrics (same content)
b1cfbb6
@SzymonPobiega
Fix rebase
b508c9a
@SzymonPobiega
Adjust the docs for the critical and processing time
a9109b6
@saratry @SzymonPobiega
Include the Outgoing messages dispatch time in the critical time.
0e25ec3
@SzymonPobiega
Apply suggestions from code review
8133ec7
@SzymonPobiega SzymonPobiega force-pushed the break-continue-trace branch from c59a596 to 92a546b Compare July 19, 2024 08:52
@SzymonPobiega SzymonPobiega merged commit 9ecb042 into master Jul 19, 2024
4 checks passed
@SzymonPobiega SzymonPobiega deleted the break-continue-trace branch July 19, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SzymonPobiega SzymonPobiega SzymonPobiega approved these changes

Assignees

@SzymonPobiega SzymonPobiega

@saratry saratry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lailabougria @SzymonPobiega @saratry @mauroservienti