Introduce a static NoOpMessageHandlingMetrics instance

Particular · Jun 21, 2024 · 1b9dc91 · 1b9dc91
1 parent c8ec43d
commit 1b9dc91
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/src/NServiceBus.Core/OpenTelemetry/Metrics/NoOpMessageHandlingMetricsFactory.cs b/src/NServiceBus.Core/OpenTelemetry/Metrics/NoOpMessageHandlingMetricsFactory.cs
@@ -13,16 +13,13 @@ class NoOpMessageHandlingMetricsFactory : IMessageHandlingMetricsFactory
     /// </summary>
     /// <param name="context">The invocation context.</param>
     /// <returns>The instantiated <c>IHandlingMetrics</c>.</returns>
-    public IMessageHandlingMetrics StartHandling(IInvokeHandlerContext context) => new NoOpMessageHandlingMetrics();
+    public IMessageHandlingMetrics StartHandling(IInvokeHandlerContext context) => NoOpMessageHandlingMetrics.Instance;
 }
 
 class NoOpMessageHandlingMetrics : IMessageHandlingMetrics
 {
-    public void OnSuccess()
-    {
-    }
-
-    public void OnFailure(Exception error)
-    {
-    }
+    public static IMessageHandlingMetrics Instance => new NoOpMessageHandlingMetrics();
+    NoOpMessageHandlingMetrics() { }
+    public void OnSuccess() { }
+    public void OnFailure(Exception error) { }
 }