Backports release 1.5-RC2 #36577
Merged
Backports release 1.5-RC2 #36577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unnecessary restriction to `StridedVecOrMat` The "Strided array interface" https://docs.julialang.org/en/v1/manual/interfaces/#man-interface-strided-arrays-1 means that this is useful beyond these types * Update adjtrans.jl * Add tests for adj/trans strides * Add tests, change strides(::Adjoint{<:Any,<:AbstractVector}) definition * stride(::AbstractrArray, k) for all k, add ConjPtr * Remove ConjPtr * Always throw an error if strides is not implemented * Update abstractarray.jl * Update blas.jl * Remove k < 1 special case * Also widen elsize to AbstractVecOrMat * Use strides for dim > ndims * Update stdlib/LinearAlgebra/test/blas.jl Co-authored-by: Matt Bauman <[email protected]> (cherry picked from commit 6b2c7f1)
(cherry picked from commit 0a4f357)
When using `return` or `break` nested inside `finally` handlers, exception stack lowering failed to pop exceptions from the stack correctly: * For `return`, the exception stack was not popped at all. If done inside a loop this could eventually cause the runtime to run out of memory. * For `break`, the exception stack was popped too early, causing subtle inconsistency in intermediate finally handlers. Fix these issues by storing the current exception token stack with the current finally handler information and using it to pop the stack before jumping into the finally block. Fixes #34579 (cherry picked from commit 16ba0dd)
(cherry picked from commit 0960c9a)
* fix broadcast for scalar cartesian indexing When broadcasting left-hand side indexing is turned into a dotview. For scalar indexing this should be equivalent to a `getindex`, but up until this patch the `CartesianIndex` would not be treated as such. This fixes e.g. broadcasting like `a[CartesianIndex(1)] .= 1` for a nested array `a`. * Also extend to `AbstractCartesianIndex`es Co-authored-by: Matt Bauman <[email protected]> (cherry picked from commit ff17412)
|
You could just push it here. |
(cherry picked from commit 6fd5b82)
The issue here is passing a `Vargarg` to `precise_container_type`, which doesn't really make sense. Instead, we need to have the caller unwrap the vararg, request the precise container type of the inner type and then re-wrap the answer in a vararg. (cherry picked from commit 63179af)
KristofferC
force-pushed
the
backports-release-1.5
branch
from
8f80474 to
678d57d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
StridedVecOrMat#35929 - Remove unnecessary restriction toStridedVecOrMatlimit_type_sizewith fall-back #36516 - Replace assertion inlimit_type_sizewith fall-backContains multiple commits, manual intervention needed: