-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update X86 feature and CPU detection #36502
Conversation
f705012
to
d38b6f7
Compare
* Deprecated features * Comments * Update dependency and processor feature set
Based on
I assume all 5 commits should be backported to 1.5 (so I did that in #36577). You could take a look if you want to see that it looks reasonable, there was only one fairly trivial (hopefully) merge conflict. |
All 5 should be safe, just that the latter 3 has a higher chance of mistake/introducing errors.... 6fd5b82 seems to be missing? That's actually the only bugfix that should be backported even if others don't. That's probablly also the origin of the conflict. |
Hm, yes. So I did mess something up. Will fix it. |
Added |
I thought about it a bit and maybe it is better to just backport the bugfix commit since we are so late in the release cycle. I changed the backport branch to that. |
First three commits assumes LLVM >= 5.0
Last two commits assumes LLVM >= 7.0 (really 8.0 but nothing was needed from 8.0)
At least the first commit should be backported to all versions that supports LLVM 8.0 ref #35215 (comment)