Replace assertion in limit_type_size with fall-back
#36516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the condition (the new type has to be wider) of the assertion should hold, #36407 shows that this may still fail sometimes. Instead of throwing an error, it seems better to just widen more aggressively if needed to ensure that the condition is fulfilled.
JeffBezanson
approved these changes
Jul 2, 2020
|
We appreciate the quick fix! We ran into those problems in #36407 quite often lately. |
|
Backport? |
13 tasks
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
While the condition (the new type has to be wider) of the assertion should hold, JuliaLang#36407 shows that this may still fail sometimes. Instead of throwing an error, it seems better to just widen more aggressively if needed to ensure that the condition is fulfilled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the condition (the new type has to be wider) of the assertion should hold, #36407 shows that this may still fail sometimes. Instead of throwing an error, it seems better to just widen more aggressively if needed to ensure that the condition is fulfilled.
Closes #36407.