Fix exception stack lowering in finally handlers #36480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c42f
added
compiler:lowering
JeffBezanson
approved these changes
Jun 30, 2020
When using `return` or `break` nested inside `finally` handlers, exception stack lowering failed to pop exceptions from the stack correctly: * For `return`, the exception stack was not popped at all. If done inside a loop this could eventually cause the runtime to run out of memory. * For `break`, the exception stack was popped too early, causing subtle inconsistency in intermediate finally handlers. Fix these issues by storing the current exception token stack with the current finally handler information and using it to pop the stack before jumping into the finally block. Fixes #34579
c42f
force-pushed
the
cjf/excstack-return-via-finally-fix
branch
from
ad159c9 to
97e8486
Compare
KristofferC
pushed a commit
that referenced
this pull request
Jul 8, 2020
When using `return` or `break` nested inside `finally` handlers, exception stack lowering failed to pop exceptions from the stack correctly: * For `return`, the exception stack was not popped at all. If done inside a loop this could eventually cause the runtime to run out of memory. * For `break`, the exception stack was popped too early, causing subtle inconsistency in intermediate finally handlers. Fix these issues by storing the current exception token stack with the current finally handler information and using it to pop the stack before jumping into the finally block. Fixes #34579 (cherry picked from commit 16ba0dd)
13 tasks
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
When using `return` or `break` nested inside `finally` handlers, exception stack lowering failed to pop exceptions from the stack correctly: * For `return`, the exception stack was not popped at all. If done inside a loop this could eventually cause the runtime to run out of memory. * For `break`, the exception stack was popped too early, causing subtle inconsistency in intermediate finally handlers. Fix these issues by storing the current exception token stack with the current finally handler information and using it to pop the stack before jumping into the finally block. Fixes JuliaLang#34579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
returnorbreaknested insidefinallyhandlers,exception stack lowering failed to pop exceptions from the stack
correctly:
return, the exception stack was not popped at all. If doneinside a loop this could eventually cause the runtime to run out of
memory.
break, the exception stack was popped too early, causing subtleinconsistency in intermediate finally handlers.
Fix these issues by storing the current exception token stack with the
current finally handler information and using it to pop the stack before
jumping into the finally block.
Fixes #34579
CC @KristofferC