FR - Language-specific templates part I #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
requested changes
Nov 28, 2019
There was a problem hiding this comment.
Interesting way of approaching the comment/comments thing! But it works and can't think of a better way.
A few additions:
- Can you make the same change to en/2019/base.html? I know you have the fallback but suspect English will be the base that people will copy from for next language so let's add it to that to give them something to work from.
- Can you add French to language.py and close FR - Language Support #563 for now?
- Can you add yourself to config/2019.json? To the developers and translators teams.
tunetheweb
reviewed
Nov 28, 2019
tunetheweb
reviewed
Nov 28, 2019
tunetheweb
reviewed
Nov 28, 2019
|
Ok done. |
(assuming I join the translators team)
- Does not conform with the CSP - Is useless with the CSS styling
Show the right word according to the number of comment.
tunetheweb
approved these changes
Nov 28, 2019
tunetheweb
reviewed
Nov 28, 2019
Co-Authored-By: Barry Pollard <[email protected]>
Co-Authored-By: Barry Pollard <[email protected]>
Co-Authored-By: Barry Pollard <[email protected]>
borisschapira
force-pushed
the
language-specific-templates-fr
branch
from
d581090 to
20c3abd
Compare
|
Thanks a lot Barry for pointing out what I had missed. |
|
@AymenLoukil / @SilentJMA can you review? Then we're good to merge this. |
tunetheweb
approved these changes
Nov 28, 2019
Co-Authored-By: Barry Pollard <[email protected]>
Co-Authored-By: Barry Pollard <[email protected]>
Co-Authored-By: Barry Pollard <[email protected]>
Co-Authored-By: Barry Pollard <[email protected]>
My contribution is nothing compared to your ability to pinpoint what I have missed. Thank you, Barry. |
Oh you better believe I'm real fun to know in real life 😀 |
SilentJMA
reviewed
Nov 29, 2019
With fallback to English team names if the dictionary is not populated. related to HTTPArchive#569
SilentJMA
reviewed
Nov 29, 2019
SilentJMA
reviewed
Nov 29, 2019
instead of duplicating HTML markup. Thanks @mikegeyser
tunetheweb
reviewed
Nov 29, 2019
tunetheweb
reviewed
Nov 29, 2019
tunetheweb
added
development
Co-Authored-By: Barry Pollard <[email protected]>
Co-Authored-By: Barry Pollard <[email protected]>
SilentJMA
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translation for the following pages in the language specific templates directory :
done according to #539.
To manage the pluralization of the word "comments", I've added some JS to show or hide the right translation strings.