Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localized Team Names #569

Merged
merged 2 commits into from
Nov 29, 2019
Merged

Localized Team Names #569

merged 2 commits into from
Nov 29, 2019

Conversation

borisschapira
Copy link
Contributor

With fallback to English team names if the dictionary is not populated.

Fixes #568

@borisschapira
Localized Team Names
8f62e59 
With fallback to English team names if the dictionary is not populated.

Fixes HTTPArchive#568
borisschapira added a commit to borisschapira/almanac.httparchive.org that referenced this pull request Nov 29, 2019
@borisschapira
FR - Localized Team Names
315fd17 
With fallback to English team names if the dictionary is not populated.
related to HTTPArchive#569
@borisschapira
Using a null coalescing operator
da7c155 
instead of duplicating HTML markup.
Thanks @mikegeyser
@mikegeyser
Copy link
Contributor

I'm happy with the chance, but it isn't strictly speaking necessary for en/2019/contributors.html. Should we not do this as a part of fr/2019/contributors.html instead?

@tunetheweb
Copy link
Member

I'm happy with the chance, but it isn't strictly speaking necessary for en/2019/contributors.html. Should we not do this as a part of fr/2019/contributors.html instead?

I think each translator will likely use en as the base, so personally I think we should do it here, rather than trying to explain to a Spanish speaker (for example) to mostly base it on the en template, but also checkout the fr template for some language-specific overrides.

WDYT?

tunetheweb
tunetheweb approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I presume we can do the same in the ToC for the Part names, and Chapter names to close #398?

@tunetheweb
Copy link
Member

I'm happy with the chance, but it isn't strictly speaking necessary for en/2019/contributors.html. Should we not do this as a part of fr/2019/contributors.html instead?

I think each translator will likely use en as the base, so personally I think we should do it here, rather than trying to explain to a Spanish speaker (for example) to mostly base it on the en template, but also checkout the fr template for some language-specific overrides.

WDYT?

And another reason for doing it in English is consistency. So if we break it (e.g. by moving from JSON to Python) then we break it in all languages and so test it (to avoid breaking it in the first place) and if we miss it there we see it broken quicker.

@tunetheweb tunetheweb added development Building the Almanac tech stack translation world wide web labels Nov 29, 2019
@tunetheweb tunetheweb added this to the Après Ski milestone Nov 29, 2019
@mikegeyser
Copy link
Contributor

I'm happy with that. 😊

@tunetheweb tunetheweb merged commit 2b6320a into HTTPArchive:master Nov 29, 2019
tunetheweb added a commit that referenced this pull request Nov 29, 2019
@borisschapira @tunetheweb
FR - Language-specific templates part I (#564)
ec783e8 
* FR - Language-specific templates part I

* Adding pluralization of the word "comment" to the EN version

* Adding French to supported languages

* Adding myself to contributors
(assuming I join the translators team)

* Removing inline style

- Does not conform with the CSP
- Is useless with the CSS styling

* Change logic for comment pluralization

Show the right word according to the number of comment.

* Translating a string

* Update src/config/2019.json

Co-Authored-By: Barry Pollard <[email protected]>

* Update src/config/2019.json

Co-Authored-By: Barry Pollard <[email protected]>

* Update src/templates/fr/2019/base_chapter.html

Co-Authored-By: Barry Pollard <[email protected]>

* Adding some missing translation on alternatives

* Add FR translation for Contributors template

* Add FR translation for Index template

* Hardcode Contributors's team names in FR

According to #568 (comment)

* Update src/templates/fr/2019/contributors.html

Co-Authored-By: Barry Pollard <[email protected]>

* Update src/templates/fr/2019/contributors.html

Co-Authored-By: Barry Pollard <[email protected]>

* Localize Breadcrumb's name

* Fixing a missed "on" => "sur"

* Update src/templates/fr/2019/base_chapter.html

Co-Authored-By: Barry Pollard <[email protected]>

* Improving alternatives on avatars

* Update src/templates/fr/2019/contributors.html

Co-Authored-By: Barry Pollard <[email protected]>

* Improving wording on "one's website" to "site web de…"

* Typofix Web Almanac

* FR - Localized Team Names

With fallback to English team names if the dictionary is not populated.
related to #569

* Using a null coalescing operator
instead of duplicating HTML markup.
Thanks @mikegeyser

* Update src/templates/fr/2019/base_chapter.html

Co-Authored-By: Barry Pollard <[email protected]>

* Update src/templates/fr/2019/chapter.html

Co-Authored-By: Barry Pollard <[email protected]>
@borisschapira borisschapira deleted the localized-team-names branch December 5, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikegeyser mikegeyser mikegeyser approved these changes

@tunetheweb tunetheweb tunetheweb approved these changes

Assignees
No one assigned
Labels
development Building the Almanac tech stack translation world wide web
Projects
None yet
Milestone
2019 Backlog
Development

Successfully merging this pull request may close these issues.

i18n - Add a way to localize teams' names.
3 participants
@borisschapira @mikegeyser @tunetheweb