i18n - Add a way to localize teams' names.

[borisschapira]

Current team names (Analysts, Authors, Brainstormers, Designers…) are use on the Contributors page to filter people. We should think about a way to localize theses teams' names.

[tunetheweb]

Related: #398 and #561

@borisschapira short term, can’t we just have buttons with local wording on the buttons but using the English categories to filter? Though I’m guessing that currently the buttons are dynamically generated so this would mean hard coding the team names? Not ideal but also I wouldn’t expect to add new teams that often so maybe acceptable...

[borisschapira]

Short term, I've added "(noms anglais)", aka "(English names)" to the "Filter by teams:" translation, because the buttons are generated from config.teams.items() and I don't know the app well enough to know where I could put a key-value mapping dictionary with the translations.

[tunetheweb]

Yes but could just replace this:

    {% for id, team in config.teams.items() %}
      <button class="{{ id }}" type="button">{{ team.name }}</button>
    {% endfor %}

with this:

      <button class="analysts" type="button">Analystes</button>
      <button class="authors" type="button">Auteurs</button>
      <button class="brainstormers" type="button">Brainstormers</button>
      ....etc.

Hardcoding as a say, but maybe sufficient - at least in short term

[borisschapira]

This presents a risk if a new team is added but if it's okay with everyone, I can do it that way.

[tunetheweb]

Agreed but think that's relatively unlikely and think it's far friendlier to French visitors so I say go for it for now. Leave this issue open for longer term options.

Also doing this for now will also give us the translations to use for when (if?) we do implement a better option. Which might be a lookup table in the Contributors chapter with fallback to English. @mikegeyser any thoughts on this?

[mikegeyser]

I think it would make sense for the base template to read the team names from a variable, and then each specific translation can override the variables in the contributors page. Something similar to how we set metadata in the chapter.html? We could just use a dictionary keyed off of config.teams[id], that gets set up in the template. (I think it's probably close to what you mean by a lookup table @bazzadp)

Edit:

Something like this:

<div class="contributor-teams">
    {% set teams = OrderedDict([
        ('analysts', 'Analystes'),
        ('authors', 'Auteurs'),
        ('brainstormers', 'Brainstormers')
    ]) %}

    {% for id in contributor.teams | sort() %}
    <span class="contributor-team team-{{ id }}">{{ teams[id] or config.teams[id].name }}</span>
    {% endfor %}
</div>

(The above is just pseudocode, I haven't run it.)

[tunetheweb]

Yes that’s what I was thinking.