Add Fugitives From Delta-V #538

Forzii · 2025-02-07T00:36:20Z

Description

Attempting to port fugitive ghost role/midround antag from Delta-V. Currently in progress, just wanted to show publicly in case anyone wants to collaborate or help me test :)

Currently known bugs:
Ratking won't spawn via dedicated event (I think an updated events.yml entity definition is needed. May be best to remove the one in Nyanotrasen like the PR wanted and define a new one in a Floof events.yml since Delta-V has disabled it alltogether. No PR to pull since it's disabled, sadly. Definition requirements have changed with new antag refactor stuff. Works fine via mousemigration event, do we actually need this ratking-specific event? Is it for admin stuff?)
Listening outpost operatives don't get codewords/briefing/objectives/role (Behavior on master is they get no role or objective but they get a briefing and codewords)
Antags spawn the appearance of your selected character unless pre-generated (is that intentional maybe? master seems to have LP operatives just generic humans)
Objective briefing doesn't work for some antags, instead literally outputting the localization string (paradox anomaly, I forget what else)
Some playtime requirement error for ListeningPost (CharacterRequirement is abstract but could not find concrete type 'OverallPlaytimeRequirement')
Probably more send help.

Evaluating the inclusion of the following PRs:

DeltaV-Station/Delta-v#1413
DeltaV-Station/Delta-v#1457 (Cleanup and move localization stuff, requires 1411 I think)
DeltaV-Station/Delta-v#1666
DeltaV-Station/Delta-v#1797
DeltaV-Station/Delta-v#1817
DeltaV-Station/Delta-v#2363
DeltaV-Station/Delta-v#2374
DeltaV-Station/Delta-v#2383

Found some dependencies I also need to cherry-pick:
space-wizards/space-station-14#28310
space-wizards/space-station-14#28366
space-wizards/space-station-14#28485 (not strictly required but tests good)
space-wizards/space-station-14#28216 (precursor to 28217)
space-wizards/space-station-14#28217 (to get BaseAntagSpawner)
space-wizards/space-station-14#28208 (to get AntagLoadProfileRule)
DeltaV-Station/Delta-v#1206 (to get BaseMidRoundAntag)
DeltaV-Station/Delta-v#1369 (I think this is needed to fix some stuff, also gets us more in parity with other DV antag stuff)
space-wizards/space-station-14#28210 (to get RuleLoadedGridsEvent)
DeltaV-Station/Delta-v#1411 (Cleanup good right?? Also pre-req for 1457 I think)
space-wizards/space-station-14#28465 (to get IsWhitelistFail)

Also needed to re-add some of the changes from this PR due to the files getting moved/refactored:
#463
#325

This change likely effects (and therefore needs tested at minimum):
Loneop
Dragon
Ratking
Thief
Traitor?
LPO
Paradox Anomaly
Fugitive
Unknown shuttle events

TODO

Media

Changelog

🆑

add: Added fun :D
tweak: Tweaked fun
fix: Fixed fun!
remove: Removed fun :(

@deltanedas

* add fugitive rule logic * add fugitive role * add fugitive event * remove nyano spawner and make midround antag spawner work real * fix announcement logic * fix the funny bug i think * fix crimes * fix crime count * 1 less min crime * fix sex (real) * thief bag unhardcode MaxSelectedSets *

*

* add fugitive stash * fix * add misc stuff and fugitive stash * m --------- Co-authored-by: deltanedas <@deltanedas:kde.org>

GameTicking.Components got moved to Shared instead of Server

@deltanedas

* add AntagObjectives from GenericAntag * add AntagRandomObjectives that traitor and thief can use * make ObjectivesSystem use initial character name which AntagSelection passes * make thief and traitor use AntagRandomObjectives * remove now unused locale * make sleeper agents rule use baseTraitorRule * restore dragon rule oop * bandaid for genericantag * real * typo --------- Co-authored-by: deltanedas <@deltanedas:kde.org>

@deltanedas

* remove dragon system usage of GenericAntag * add AntagRandomSpawn for making antags spawn at a random tile * add AntagSpawner to make an antag spawner just spawn an entity * add antag prototype for dragon since it never had one * make dragon spawner a GhostRoleAntagSpawner, remove GenericAntag * make dragon rule use AntagSelection and stuff * remove dragon GenericAntag rule * add back to spawn menu --------- Co-authored-by: deltanedas <@deltanedas:kde.org>

But now there are load errors :(

@deltanedas

* move profile loading out of nukeops rule * make BaseNukeopsRule and use AntagLoadProfileRule * untroll --------- Co-authored-by: deltanedas <@deltanedas:kde.org>

I accidentally left an extra line in that roundstart.yml during the cherry-pick, and I needed a work-around for a nullable type issue.

@deltanedas

* move paradox code around and update it * make MidRoundAntagRule just give spawn locations * update the yaml * give anom and listening post raffles --------- Co-authored-by: deltanedas <@deltanedas:kde.org> Co-authored-by: Null <[email protected]>

This was supposed to be deleted by the previous cherry-pick but wasn't for some reason.

Attempted to readd Fansana#463 in the new paradox anomaly code.

Added Floofstation comments

@deltanedas

* rename pirate radio map to listening post, change spawner prototype * refactor pirate radio spawn rule into DebrisSpawner and LoadFarGrid * remove obsolete yml * -m make listening post rule use new stuff and antag selection * other changes * fixes * more * fixy * fix nan * final fix * what --------- Co-authored-by: deltanedas <@deltanedas:kde.org>

Fixed Gameticking.Components discrepency

*

@deltanedas

* remove unused terminator code * remove genericantag usage, put everything on the real rule * hide spawner from spawn menu * remove terminator locale --------- Co-authored-by: deltanedas <@deltanedas:kde.org>

Added TerminatorComponent from Delta-V repository due to paradox anomaly reliance on it, and also replaced an unintentional instance of nospawn with the HideSpawnMenu category.

* Replace obsolete whitelist is valid with whitelist system * Consistency * Fix logic * Bork * I figured out how to get whitelists on the client lol * test fail * woops * HELP ME FUNCTIONS * Fix errors * simplify --------- Co-authored-by: plykiya <[email protected]>

Reverted the changes to the GatherableSystem due to incompatibility caused by a different PR I don't want to pull as part of this. Also commented out Paradox anomaly guaranteed psionics - it was causing errors likely due to a missing dependency. A problem for another day, perhaps.

Switched the listening outpost event to use the Floof "pirateradio" map and modified the map spawnpoint prototype similar to Delta-V PR 1369

Disabled kill and friend objectives, made custom rules, and attempted to make custom role briefing.

@deltanedas

* ensure everything has proper locale, remove more terminator stuff * remove all unused terminator bits * remove terminator objectives --------- Co-authored-by: deltanedas <@deltanedas:kde.org>

github-actions · 2025-02-13T16:38:34Z

RSI Diff Bot; head commit 1d4c83f merging into 27fb1d8
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Species/Terminator/parts.rsi

State	Old	New	Status
full			Removed
head_f			Removed
head_m			Removed
l_arm			Removed
l_foot			Removed
l_hand			Removed
l_leg			Removed
r_arm			Removed
r_foot			Removed
r_hand			Removed
r_leg			Removed
skull_icon			Removed
torso_f			Removed
torso_m			Removed

Forzii · 2025-02-16T00:53:02Z

I don't really want to yet, but this will probably be closed either by me or one of the maintainers. Probably too many out-of-order upstream cherry-picks (I think there's 8 from wizden in there right now). I'm going to look into how I can help us get the upstream changes the planned way instead (whatever that entails, I dunno yet). Then I can come back to the Delta-V antag changes and additions (fugitive and syndicate recruiter specifically are my target) once we have the right upstream changes.

Edit: Also I don't really like how big the PR has gotten anyway. If I am going to do this stuff now (rather than whatever the "normal" catchup path is, I'd like to split a lot of this into different PRs.

github-actions · 2025-02-18T22:39:30Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Forzii · 2025-02-21T00:55:52Z

I'm going to close this and perhaps make another attempt after the next upstream merge.

github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files labels Feb 7, 2025

Tayrtahn and others added 7 commits February 7, 2025 11:19

Add LocalizedDatasetPrototype (#28310)

8f91109

Fix off-by-one error in LocalizedDatasetPrototype (#28366)

8ca7f42

Add integration test for LocalizedDatasets (#28485)

511592d

Update FugitiveRule.cs

3e83c7a

GameTicking.Components got moved to Shared instead of Server

Bapped some build errors

88fe833

But now there are load errors :(

Floof-Station-Bot changed the title ~~Add fugitives from Delta-V~~ Add Fugitives From Delta-V Feb 9, 2025

deltanedas and others added 7 commits February 8, 2025 23:13

move nukie profile loading into its own rule (#28208)

02233ec

* move profile loading out of nukeops rule * make BaseNukeopsRule and use AntagLoadProfileRule * untroll --------- Co-authored-by: deltanedas <@deltanedas:kde.org>

Bugfix and workaround

cb1e1d7

I accidentally left an extra line in that roundstart.yml during the cherry-pick, and I needed a work-around for a nullable type issue.

paradox anomaly antag rework (#1206)

348f896

* move paradox code around and update it * make MidRoundAntagRule just give spawn locations * update the yaml * give anom and listening post raffles --------- Co-authored-by: deltanedas <@deltanedas:kde.org> Co-authored-by: Null <[email protected]>

Delete ParadoxAnomalySystem.cs

71c5d0e

This was supposed to be deleted by the previous cherry-pick but wasn't for some reason.

Readd paradox anomaly opt-out functionality

7722fcc

Attempted to readd Fansana#463 in the new paradox anomaly code.

Add comments to ParadoxClonerRule.cs changes

5ef3e9f

Added Floofstation comments

github-actions bot added the Changes: Map Changes any yml file in the Maps directories label Feb 10, 2025

Forzii and others added 9 commits February 9, 2025 21:19

Update LoadFarGridRule.cs

07edee2

Fixed Gameticking.Components discrepency

LoadMapRule grid storage rework (#28210)

8f5fee6

*

paradox code cleanup (#1411)

4f06490

* remove unused terminator code * remove genericantag usage, put everything on the real rule * hide spawner from spawn menu * remove terminator locale --------- Co-authored-by: deltanedas <@deltanedas:kde.org>

Add TerminatorComponent and ghost_roles tweak

9f5e5f6

Added TerminatorComponent from Delta-V repository due to paradox anomaly reliance on it, and also replaced an unintentional instance of nospawn with the HideSpawnMenu category.

Switch to Floof LPO map

e886cce

Switched the listening outpost event to use the Floof "pirateradio" map and modified the map spawnpoint prototype similar to Delta-V PR 1369

Paradox anomaly tweaks

937e94b

Disabled kill and friend objectives, made custom rules, and attempted to make custom role briefing.

cleanup antag locale and stuff (#1457)

1d4c83f

* ensure everything has proper locale, remove more terminator stuff * remove all unused terminator bits * remove terminator objectives --------- Co-authored-by: deltanedas <@deltanedas:kde.org>

github-actions bot added the Changes: Sprite Changes any png or json in an RSI label Feb 13, 2025

github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Feb 18, 2025

Forzii closed this Feb 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Fugitives From Delta-V #538

Add Fugitives From Delta-V #538

Forzii commented Feb 7, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025

Forzii commented Feb 16, 2025 •

edited

Loading

github-actions bot commented Feb 18, 2025

Forzii commented Feb 21, 2025

Add Fugitives From Delta-V #538

Add Fugitives From Delta-V #538

Conversation

Forzii commented Feb 7, 2025 • edited Loading

Description

TODO

Media

Changelog

github-actions bot commented Feb 13, 2025

Forzii commented Feb 16, 2025 • edited Loading

github-actions bot commented Feb 18, 2025

Forzii commented Feb 21, 2025

Forzii commented Feb 7, 2025 •

edited

Loading

Forzii commented Feb 16, 2025 •

edited

Loading