antag objective issuing refactor #28216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S: Needs Review
This was referenced May 23, 2024
Merged
This was referenced May 23, 2024
added 2 commits
May 23, 2024 08:08
|
picks20 lives another day |
Erisfiregamer1
pushed a commit
to The-Arcadis-Team/arc-station-14
that referenced
this pull request
Jan 9, 2025
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
instead of every system that has random objectives copy pasting shit, add
AntagRandomObjectivesto the gamerule ymlalso moved fixed objectives part of genericantag into its own component AntagObjectivesComponent, which currently thief uses but will make everything that used genericantag use it too before nuking it entirely
Why / Balance
negative diff (with genericantag deleted) good
Technical details
an
AntagObjectiveSetdefines the objective groups prototype, probability of the set being used, the max tries it can haveAntagRandomObjectivescan have multiple sets, like thief which has 70% chance of adding 1 animal objective and guaranteed chance of trying to add up to 10 normal objectives, difficulty permittingtraitor just has 1 set of
groups: TraitorObjectiveGroupssince it doesnt do anything funnyMedia
it work
Breaking changes
TraitorRuleandThiefRuleno longer add objectives, they needAntagRandomObjectivesin the gamerule nowChangelog
no cl no fun