Add integration test for LocalizedDatasets #28485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tayrtahn
added
the
S: DO NOT MERGE
Tayrtahn
removed
the
S: DO NOT MERGE
AJCM-git
requested changes
Jun 3, 2024
Content.IntegrationTests/Tests/Localization/LocalizedDatasetPrototypeTest.cs
Outdated
Show resolved
Hide resolved
AJCM-git
added
the
S: Awaiting Changes
github-actions
bot
added
S: Needs Review
AJCM-git
approved these changes
Jun 3, 2024
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adds an integration test that makes sure that all of the LocId strings that can be obtained from all the
LocalizedDatasetPrototypes have corresponding Fluent strings loaded into the localization manager.Why / Balance
This is going to fail with the current master, since there's a gap in the Tips dataset (entry 51 is missing). This will help prevent that from happening again. See #28486.
Technical details
Very simple test. Just iterates over the prototypes, iterates over the values returned by each one, and calls ILocalizationManager.HasString to test if they exist.
Media
Code.
Breaking changes
Changelog
Nah.