-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoadMapRule grid storage rework #28210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
mirrorcult
previously requested changes
May 31, 2024
AJCM-git
requested changes
Jun 3, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
AJCM-git
approved these changes
Jun 3, 2024
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
moved Map and MapGrids into its own component RuleGridsComponent
antag spawner finding is moved to RuleGridsSystem
Why / Balance
Technical details
other systems can also subscribe to this to do work right after the grids are loaded, or they can access Map and MapGrids from the component when the rule is started.
ForceEndSelf
fromStationEventSystem
toGameRuleSystem
since its useful, events can still use it because of inheritanceMedia
loneop still works

Breaking changes
LoadMapRule
now requires the newRuleGrids
component to spawn antags on it and have grids looked up later.Changelog
no cl no fun