Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadMapRule grid storage rework #28210

Merged
merged 11 commits into from
Jun 4, 2024
Merged

Conversation

deltanedas
Copy link
Contributor

@deltanedas deltanedas commented May 23, 2024

About the PR

moved Map and MapGrids into its own component RuleGridsComponent
antag spawner finding is moved to RuleGridsSystem

Why / Balance

  • map loader shouldnt care about antag stuff
  • antag stuff shouldnt care about how grids are loaded, you can use a system that isnt LoadMapRule

Technical details

  • added RuleLoadedGridsEvent which makes RuleGridsComponent store the grids a system loaded
    other systems can also subscribe to this to do work right after the grids are loaded, or they can access Map and MapGrids from the component when the rule is started.
  • anything checking LoadMapRule for grids now checks RuleGrids instead
  • made maps created by LoadMapRule no longer have a debug name (which was visible on shuttle console !!! not confusing at all) and instead its just logged
  • if LoadMapRule fails to load a map it actually logs it and ends the rule
  • if preloading is disabled it immediately ends the rule instead of having nullspace ghost roles :trollface: or failing tests :trollface:
  • moved ForceEndSelf from StationEventSystem to GameRuleSystem since its useful, events can still use it because of inheritance

Media

loneop still works
03:51:10

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

LoadMapRule now requires the new RuleGrids component to spawn antags on it and have grids looked up later.

Changelog
no cl no fun

@deltanedas deltanedas requested a review from EmoGarbage404 as a code owner May 23, 2024 02:34
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label May 23, 2024
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label May 25, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label May 26, 2024
@deltanedas deltanedas requested a review from mirrorcult June 3, 2024 19:56
@AJCM-git AJCM-git added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Jun 3, 2024
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jun 3, 2024
@deltanedas deltanedas requested a review from AJCM-git June 3, 2024 23:40
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Jun 3, 2024
@AJCM-git AJCM-git merged commit 16b3fb1 into space-wizards:master Jun 4, 2024
12 checks passed
@deltanedas deltanedas deleted the grid-ops branch June 4, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants