Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2025-02-12 #56784

Open
48 of 55 tasks
github-actions bot opened this issue Feb 12, 2025 · 21 comments
Open
48 of 55 tasks

Deploy Checklist: New Expensify 2025-02-12 #56784

github-actions bot opened this issue Feb 12, 2025 · 21 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2025

Release Version: 9.0.98-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Feb 12, 2025
@Julesssss Julesssss self-assigned this Feb 12, 2025
@mountiny
Copy link
Contributor

Demoted #56812

@mountiny
Copy link
Contributor

#56798 is a new expected behaviour

@mountiny
Copy link
Contributor

#56799 is new expected behaviour

@mountiny
Copy link
Contributor

demoted #56805 - per diem is behind beta

@mountiny
Copy link
Contributor

Demoted #56806 as its a new feature

@mountiny
Copy link
Contributor

Demoted #56807

@mountiny
Copy link
Contributor

Demoted #56809

@mountiny
Copy link
Contributor

demoted #56810

@lakchote
Copy link
Contributor

Demoted #56814 for this reason

@mountiny
Copy link
Contributor

Demoted #56813

@izarutskaya
Copy link

Regression is at 93% completed.

Unchecked PRs:
#49539 - failing with #49539 (comment), #49539 (comment) pending validation on mWeb, Desktop, Android and iOS
#56188 - failing on all platforms #56347 (comment)

DB:
#56796
#56797
#56800
#56801
#56803
#56804
#56815
#56816
#56817

@mountiny
Copy link
Contributor

demoted #56817

@izarutskaya
Copy link

Regression is completed.

Unchecked PRs:
#49539 - failing with #49539 (comment), #49539 (comment)
#54406 - failing on Android and iOS apps with original bug ID. Can I check off by this comment #54406 (comment) ?
#55345 - found issue on a Desktop #55345 (comment)
#56188 - failing on all platforms #56188 (comment)
#56347 - failing with issue #56347 (comment)

DB:
#56796
#56797
#56800
#56801
#56803
#56804
#56815
#56816
#56825
#56839

@Julesssss
Copy link
Contributor

Mostly related to the navigation refactor. Some minor, but the team is on top of them. @mountiny no pressure to solve all of them today as we deployed every day this week so far (and I'm focused on a problematic regression for migrate/redirection).

@Julesssss
Copy link
Contributor

Checked off a couple of blockers

@mountiny
Copy link
Contributor

#56803 demoting

@kavimuru
Copy link

kavimuru commented Feb 13, 2025

Regression is completed.

Unchecked PRs:
#49539 - failing with #49539 (comment), #49539 (comment)
#54406 failing with #53702 original bug ID
#55345 failing with #56824 repro in PROD checking it off
#56188 - failing on all platforms with #56842

#56347 (comment)

DB:
#56796
#56797
#56800
#56801
#56803
#56804
#56815
#56816
#56825
#56839

We are still able to reproduce the following critical test case bugs:
Create account - Desktop app opens with Magic Link #20121
Create and validate a new account with magic code - #55771
Admin - Issue a new card (VBA flow) -#52199
Pending transaction is created in the account - #48597

@Julesssss
Copy link
Contributor

@Julesssss
Copy link
Contributor

Checked off #56804

@Julesssss
Copy link
Contributor

Checked off #56815

@Julesssss
Copy link
Contributor

Julesssss commented Feb 14, 2025

The final item to checkoff is #56873 and I don't think it needs to be a blocker so have demoted it. But due to DBSF I am not shipping.

To next weeks deployer you should review this one before closing out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants