[Due for payment 2025-02-25] Track expense-RHP reopens after changing category on confirm page & clicking back button twice

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Submit an expense to self DM.
4. Click Categorize it.
5. If upgrade modal appears, upgrade it and click Got it, thanks.
6. Select a category.
7. On confirmation page, click Category field.
8. Select a different category.
9. Click RHP back button.
10. Click RHP back button again.

Expected Result:

RHP will dismiss.

Actual Result:

RHP returns to confirmation page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6741352_1739405431348.20250213_080711.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

RHP returns to confirmation page.

What is the root cause of that problem?

We navigate to a confirmation screen in:

App/src/pages/iou/request/step/IOURequestStepCategory.tsx

Line 135 in a0a2609

Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(action, iouType, transactionID, report.reportID));

when editing the category, so in the stack, there are two confirmation screens.

What changes do you think we should make in order to solve the problem?

The condition to call the navigate function:

App/src/pages/iou/request/step/IOURequestStepCategory.tsx

Line 133 in a0a2609

if (action === CONST.IOU.ACTION.CATEGORIZE) {

can be updated to:

        if (action === CONST.IOU.ACTION.CATEGORIZE && !backTo) {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

It is navigation issue, don't need test.

What alternative solutions did you explore? (Optional)

[jliexpensify]

@techievivek pretty sure this isn't a deploy blocker, right?

[mountiny]

FYI most likely related to https://expensify.slack.com/archives/C01GTK53T8Q/p1739435484596829?thread_ts=1739328522.587109&cid=C01GTK53T8Q and we are discussing and working on solutions for this

[mountiny]

I think this should be quick to fix while I agree its not the most critical issue we have and could be demoted if necessary. But lets try to fix it

[WojtekBoman]

I believe it will solve this issue #56804 (comment)

[mountiny]

@WojtekBoman could someone please raise a PR for this one? thank you!

[thelullabyy]

@mountiny If my solution can address the issue and an external member can work on this issue, I can raise a PR.

[mountiny]

@thelullabyy going to handle this with SWM as they worked on this one, thank you for offering help

[Julesssss]

Merged PR, CPing here.

[thelullabyy]

@Julesssss The merged PR reflects the solution I suggested earlier. I understand it’s not an external issue, but would it be possible to consider a small payment for my involvement in this case?

[Julesssss]

@Julesssss The merged PR reflects the solution I suggested earlier. I understand it’s not an external issue, but would it be possible to consider a small payment for my involvement in this case?

I'll leave that decision to @mountiny as he has more context, I'm just merging the existing discussed PR.

[m-natarajan]

Not reproducible

Recording.36.3.mp4

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.99-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Navigation] Track expense-RHP reopens after changing category on confirm page & clicking back button twice #56868

If no regressions arise, payment will be issued on 2025-02-25. 🎊

For reference, here are some details about the assignees on this issue:

• @WojtekBoman does not require payment (Contractor)
• @dukenv0307 requires payment through NewDot Manual Requests

[melvin-bot]

@dukenv0307 @jliexpensify @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[dukenv0307]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: None

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Launch the app
2. Go to self DM.
3. Submit an expense to self DM.
4. Click Categorize it.
5. If upgrade modal appears, upgrade it and click Got it, thanks.
6. Select a category.
7. On confirmation page, click Category field.
8. Select a different category.
9. Click RHP back button.
10. Click RHP back button again.
11. Verify if the RHP has been dismissed.

Do we agree 👍 or 👎

[jliexpensify]

Payment Summary

• C+: @dukenv0307 $250 (to be paid via ND requests)