[NO QA] Add a multiple receipt addendum to FAQ #56380

greg-schroeder · 2025-02-04T20:30:18Z

Explanation of Change

Adding a small addendum to the FAQ for this article to accommodate multiple receipt uploads

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/465282

QA Steps

Go to help.expensify.com
Navigate to Expensify Classic > Integrations > Accounting Integrations > Indirect Accounting Integrations
Verify that the article has new content added and there are no formatting errors

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videosundefined

melvin-bot · 2025-02-04T20:30:24Z

melvin-bot · 2025-02-04T20:30:27Z

@ishpaul777 @laurenreidexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

docs/articles/new-expensify/expenses-&-payments/Create-an-expense.md

OSBotify · 2025-02-04T20:33:02Z

A preview of your ExpensifyHelp changes have been deployed to https://15f9b904.helpdot.pages.dev ⚡️

…nse.md Co-authored-by: Ishpaul Singh <[email protected]>

melvin-bot · 2025-02-04T20:44:39Z

melvin-bot · 2025-02-04T20:44:41Z

@Pujan92 @ @bfitzexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

greg-schroeder · 2025-02-04T20:44:45Z

Oops, yes, thanks @ishpaul777!

Pujan92 · 2025-02-06T06:43:29Z

@laurenreidexpensify Plz remove me from reviewer, Thanks!

laurenreidexpensify

@greg-schroeder The question is about multiple expenses, but the answer sounds like it's more specifically about two expenses?

Maybe something like:

One suggested way to do this, is to combine your receipts into a single PDF file before uploading to Expensify.

greg-schroeder · 2025-02-07T17:31:52Z

@laurenreidexpensify Okay. I edited one word to make it apply to "all" receipts instead of "both".

laurenreidexpensify · 2025-02-10T10:05:18Z

@greg-schroeder nice thanks, but it still says both in the last sentence?

From there, simply upload the combined PDF to the expense to capture both.

greg-schroeder · 2025-02-10T19:39:15Z

Updated

greg-schroeder · 2025-02-11T17:35:57Z

Sorry @ishpaul777 you prob shouldn't have been assigned but do you mind just re-approving so I can proceed?

melvin-bot · 2025-02-11T17:37:09Z

melvin-bot · 2025-02-11T17:37:11Z

@Gonals @Christinadobrzyn One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-02-11T17:37:14Z

🎯 @ishpaul777, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #56695.

github-actions · 2025-02-12T22:26:59Z

🚀 Deployed to staging by https://github.com/Gonals in version: 9.0.98-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Add a multiple receipt addendum to FAQ

13c5275

greg-schroeder requested a review from a team February 4, 2025 20:30

greg-schroeder self-assigned this Feb 4, 2025

melvin-bot bot requested review from ishpaul777 and laurenreidexpensify and removed request for a team February 4, 2025 20:30

greg-schroeder removed the request for review from ishpaul777 February 4, 2025 20:30

ishpaul777 reviewed Feb 4, 2025

View reviewed changes

docs/articles/new-expensify/expenses-&-payments/Create-an-expense.md Outdated Show resolved Hide resolved

Update docs/articles/new-expensify/expenses-&-payments/Create-an-expe…

195bd94

…nse.md Co-authored-by: Ishpaul Singh <[email protected]>

greg-schroeder requested a review from a team as a code owner February 4, 2025 20:44

melvin-bot bot requested review from bfitzexpensify and Pujan92 February 4, 2025 20:44

melvin-bot bot removed the request for review from a team February 4, 2025 20:44

laurenreidexpensify removed the request for review from bfitzexpensify February 5, 2025 09:16

laurenreidexpensify removed the request for review from Pujan92 February 6, 2025 09:37

laurenreidexpensify reviewed Feb 6, 2025

View reviewed changes

Small edit

b49c633

Small edit

41358ac

laurenreidexpensify approved these changes Feb 11, 2025

View reviewed changes

greg-schroeder requested a review from ishpaul777 February 11, 2025 17:35

ishpaul777 approved these changes Feb 11, 2025

View reviewed changes

melvin-bot bot requested review from Christinadobrzyn and Gonals February 11, 2025 17:37

melvin-bot bot mentioned this pull request Feb 11, 2025

Payment issue for E/App PR#56380 #56695

Closed

Gonals approved these changes Feb 12, 2025

View reviewed changes

Gonals merged commit 2fbd77a into main Feb 12, 2025
8 of 11 checks passed

Gonals deleted the greg-update-create-an-expense branch February 12, 2025 16:53

github-actions bot mentioned this pull request Feb 12, 2025

Deploy Checklist: New Expensify 2025-02-12 #56784

Open

56 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NO QA] Add a multiple receipt addendum to FAQ #56380

[NO QA] Add a multiple receipt addendum to FAQ #56380

greg-schroeder commented Feb 4, 2025 •

edited by github-actions bot

Loading

melvin-bot bot commented Feb 4, 2025 •

edited by laurenreidexpensify

Loading

melvin-bot bot commented Feb 4, 2025

OSBotify commented Feb 4, 2025 •

edited

Loading

melvin-bot bot commented Feb 4, 2025 •

edited by laurenreidexpensify

Loading

melvin-bot bot commented Feb 4, 2025

greg-schroeder commented Feb 4, 2025

Pujan92 commented Feb 6, 2025

laurenreidexpensify left a comment

greg-schroeder commented Feb 7, 2025

laurenreidexpensify commented Feb 10, 2025

greg-schroeder commented Feb 10, 2025

greg-schroeder commented Feb 11, 2025

melvin-bot bot commented Feb 11, 2025

melvin-bot bot commented Feb 11, 2025

melvin-bot bot commented Feb 11, 2025

github-actions bot commented Feb 12, 2025

[NO QA] Add a multiple receipt addendum to FAQ #56380

[NO QA] Add a multiple receipt addendum to FAQ #56380

Conversation

greg-schroeder commented Feb 4, 2025 • edited by github-actions bot Loading

Explanation of Change

Fixed Issues

QA Steps

PR Author Checklist

Screenshots/Videosundefined

melvin-bot bot commented Feb 4, 2025 • edited by laurenreidexpensify Loading

Concierge reviewer checklist:

melvin-bot bot commented Feb 4, 2025

OSBotify commented Feb 4, 2025 • edited Loading

melvin-bot bot commented Feb 4, 2025 • edited by laurenreidexpensify Loading

Concierge reviewer checklist:

melvin-bot bot commented Feb 4, 2025

greg-schroeder commented Feb 4, 2025

Pujan92 commented Feb 6, 2025

laurenreidexpensify left a comment

Choose a reason for hiding this comment

greg-schroeder commented Feb 7, 2025

laurenreidexpensify commented Feb 10, 2025

greg-schroeder commented Feb 10, 2025

greg-schroeder commented Feb 11, 2025

melvin-bot bot commented Feb 11, 2025

Concierge reviewer checklist:

melvin-bot bot commented Feb 11, 2025

melvin-bot bot commented Feb 11, 2025

github-actions bot commented Feb 12, 2025

greg-schroeder commented Feb 4, 2025 •

edited by github-actions bot

Loading

melvin-bot bot commented Feb 4, 2025 •

edited by laurenreidexpensify

Loading

OSBotify commented Feb 4, 2025 •

edited

Loading

melvin-bot bot commented Feb 4, 2025 •

edited by laurenreidexpensify

Loading