-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Due for payment 2025-02-25] PR56347-Per Diem-After selecting Dates, the flow goes back to the country list page #56805
Comments
Triggered auto assignment to @robertjchen ( |
Triggered auto assignment to @MitchExpensify ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Per diem is still behind beta so no need to block @FitseTLT Can you please follow up on this one and fix this bug? |
per #56347 |
I am afk to check this right now. But the change we made was on the Subrate step page but this one is failing in the navigation before that page. @mountiny Are you sure this is because of the linked PR? |
Hey, I'll take a look at it :) |
@mananjadhav This is highly likely caused by the navigation change - SWM will look as well |
Verified fixed |
The related PR for the fix is deployed on production. There will be a payout for me on the review. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.99-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-02-25. 🎊 For reference, here are some details about the assignees on this issue:
|
@mananjadhav @MitchExpensify @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #56347
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 10/ Chrome, Samsung S23FE/ Android 14
App Component: Money Requests
Action Performed:
Precondition:
Workspace has per diem rates.
Steps:
Expected Result:
The Select a Subrate and Quantity page is displayed.
Actual Result:
After selecting Dates, the flow goes back to the country list page. It's not possible to complete the Per Diem flow.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6741365_1739406720789.Broken_flow.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @MitchExpensifyThe text was updated successfully, but these errors were encountered: