Deploy Checklist: New Expensify 2024-11-22

[github-actions]

Release Version: 9.0.66-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Enlarge emojis in other contexts than just single character messages #47547
• [Debug Mode] Add transaction and violation data to debug mode  #50745
• Fix reply in thread shows for thread parent #51721
• Fix pressing emoji button while a context menu is shown doesn't open the emoji picker #51938
• [NoQA] e2e: close ANR popup in case if exception happened #52121
• fix: mWeb - Chat - Part of the #Admins welcome message is still in english when changing language. #52159
• Refactor IOU.requestMoney function #52231
• clean: moved Category OptionListUtils over to CategoryOptionListUtils #52250
• Feature: Per Diem Rates Settings Page #52269
• [NoQA] Update the checklists and proposal template to include requirement of unit tests #52439
• Show search action buttons v2 #52441
• Fix disappearing background on Search page #52481
• add not found page for page accessed through link #52593
• ensure consistent profile picture shape in shared QR code #52605
• Feat/50902 gr step 6 agreements and finish screen #52614
• Remove links to the tour after it has been viewed from anywhere #52617
• [NO QA] Replace "policy" with "workspace" in all help docs #52686
• refactor: remove avatarFileName from report_ #52690
• refactor: move isLoadingPrivateNotes key to reportMetadata_ #52693
• [NoQA] Fix reauthentication #52727
• Fix new ws member isn't highlighted #52750
• [No QA] chore: remove transactionThreadReportID from Report type #52773
• Fix: Number fields being unclickable on the new contact method verification page in Android. #52802
• Fix new message marker shows when creating a new expense #52811
• Fix not found page shows when open a new thread #52815
• Fix bug with default accounts for QBD #52819
• Use reconnect when starting hybrid app #52824
• Update en.ts #52832
• [NO QA] Update Connect-a-Business-Bank-Account.md #52849
• Update PULL_REQUEST_TEMPLATE.md #52852
• Update en.ts #52859
• Onyx Migration For #50796 #52884
• Fix - [CRITICAL] Multiple workspaces get created when someone either refreshes the page, or drops off and returns later. #52899
• Fix spanish translation for borrar gastos #52929
• [NoQA] Update Netsuite-Troubleshooting.md #52940
• Update copy on the app preferences page #52944
• [NoQA] Update and rename Create-and-Pay-Bills.md to Receive-and-Pay-Bills.md #52947
• Fix: Workspace - Correct message shown in delete modal while deleting from profile page #52957
• [No QA] Update Claim-And-Verify-A-Domain.md #52964
• Update CONTRIBUTING.md #52982
• [CP Staging] display "Take a 2-minute tour" task in Concierge chat for "Track and Budge Expenses" #52990
• [CP Staging] Fix package react-native-quick-sqlite link #53049
• [CP Staging] Fix optimistic report status is not set correctly #53050
• [CP Staging] Fix not found view when linking to a message #53064
• [CP Staging] Do not make requests to backend when clicking on tour link for anonymous users visiting public rooms #53069
• [CP Staging] [HybridApp] Fix deeplinks when clicking on app icon #53074

Internal QA:

• [Internal QA] [Company cards] Navigate to some other existing feed after removing one #52893 - @mountiny
• [Internal QA]: Add amex custom feed new option #52890 - @mountiny
• Chore/52820 workspace cards cleanup #52871 - @mountiny
• fix statement modal being broken on staging environment #52799 - @thienlnam
• [Internal QA]: Update copy on custom feed details page #52708 - @mountiny
• [No QA] Update force upgrade modal #52703 - @Julesssss
• Feat: Add a step to to Request Physical Card form that collects a magic code #51135 - @NikkiWines

Deploy Blockers:

• [HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] Chat - There is no “Take a 2-minute tour” task at the Concierge chat #52985
• [HOLD for payment 2024-12-07] Debug Mode - "Hmm... it's not here page" is shown when deleting a created violation #52997
• Hybrid - Android - App crashes on tapping "Domains" in settings page #52998
• [HOLD for payment 2024-01-03][$250] [Search v1.2] - Pay button does not appear when user owes money after deleting expense #52999
• Room - Who can post displays All members after setting it to Admins  #53002
• [HOLD for payment 2024-12-16] Search - No sound when paying expense in Search #53009
• Debug - There is no error message when selecting taxAmountChanged violation #53010
• [HOLD for payment 2024-12-19] [Search v1.2] - Different approval behavior when approving one held expense vs multiple held expenses #53012
• [HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] Expense - Workspace chat shows Not here page when it is created from "Pay with Expensify" #53013
• [Due for payment 2025-02-25] Per diem - Settings page is blank when categories are disabled #53016
• [HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] Save the world-The #teachers-unite is not loading after completing the "I know a teacher" flow #53022
• Search - Pay button does not appear on the expense after the duplicates are sorted #53023
• [HOLD for payment 2025-01-02] Debug Mode - "Create" button flash after creating a violation #53027
• [HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] Android Hybrid - Login - Blank page if logging in via Magic Link and crash if resending link #53033
• [HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] Thread - App opens not here page when returning to previous page from thread #53040
• [HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] "You don't have the permission to take the requested action" when opening public room thread #53042
• [HOLD Swift fix] Update to react-native-nitro-sqlite #53063
• App crashes when deeplinking to any room as anonymous user #53099
• Hybrid - Android - Chat - Compose box does not move above keyboard #53119

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.66-0 🚀

[carlosmiceli]

Demoted #52999

[kavimuru]

Regression is 1% left:
unchecked PRs:
#50745 failing with #53010
Failing with original KI #52481 (comment)
#52617 failing with #52985
#52441 web pending
#52593 iOS is pending
#52819 iOS and desktop pending
#52824 iOS pending
#52899 iOS pending

[mountiny]

Checking #52799 off as this works in production so we do not have to hold deploy on it, but @thienlnam @blimpich still please QA this in staging when you get a moment, thanks!

[mountiny]

Demoting #53027 and #53010 they are debug features

[kavimuru]

Regression is completed
unchecked PRs:
#50745 failing with #53010
#52481 Failing with original KI #52481 (comment)
#52617 failing with #52985
#52441 failing with #53018 but repro in PROD checking it off

#52481 - failing with #51735
#52593 verified in stand alone in native apps, tapping the link opens in the ND and not in the HybridApp. But works fine in all other platforms.
#52819 iOS and desktop pending
#52899 failing in iOS and desktop with original bug id #52894

[mountiny]

Checking #50745 off as it's not a blocker
Checking #52481 off as the failing issue is the original KI
Checking #52617 off as the linked issue is being addressed
Checking #52899 off as the linked issue if the original KI and the authors are looking into it

[mountiny]

Demoting #52997 as its a debug mode related issue

[NikkiWines]

Checking off #51135 as it passes QA - see here

[mountiny]

#53002 was demoted

[mountiny]

demoting #53012

[mountiny]

Demoted #53023

[joekaufmanexpensify]

QA passed #52708

[joekaufmanexpensify]

QA done #52871

[joekaufmanexpensify]

QA passed #52890

[joekaufmanexpensify]

QA passed #52893

[mountiny]

All deploy blocker PRs been cped and awaiting deployment, then QA can retest

[mountiny]

no specific crashes for newdot only, hybrid app saw some crashes that are hopefully addressed with the CP

[mountiny]

Just pending the Cped PR validation

[kavimuru]

#53069 Failing with #53099

[chiragsalian]

@kavimuru, we just CP'd a hybridApp fix for this - #53099
Can you retest on hybridApp ios and android if the issue still persists. Version 9.0.66-7.

[mvtglobally]

App is still failing on 9.0.66-7

trim.C95607AD-579B-4E99-8EBC-350D7437F778.MOV

[mountiny]

Working on it here

[mountiny]

With the last CP we have confirmed that:

• App crashes when deeplinking to any room as anonymous user #53099
• Hybrid - Android - Chat - Compose box does not move above keyboard #53119
  are fixed in the latest version of the native hybrid app 9.0.66-8

In this slack thread we confirmed the latest CP fixed these issues

[mountiny]

oooooookay, all clear

[mountiny]