Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] Save the world-The #teachers-unite is not loading after completing the "I know a teacher" flow #53022

Closed
3 of 8 tasks
lanitochka17 opened this issue Nov 23, 2024 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: Y
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5256845&group_by=cases:section_id&group_id=229065&group_order=asc
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to http://staging.new.expensify.com/
  2. Login with a new Expensifail account or one that is NOT part of the "Teachers Unite! testing policy"
  3. Navigate to Profile settings
  4. Tap "Save the World"
  5. Tap "I know a teacher"
  6. Fill the first and last name
  7. For the email, enter a new Expensifail account

Expected Result:

The user is redirected to a public room with a whisper message indicating you referred a teacher

Actual Result:

The #teachers-unite is not loading after completing the "I know a teacher" flow

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6673915_1732346142738.teachers-unite_not_loading_STAGING.mp4
Bug6673915_1732346339567!Screenshot_2024-11-23_at_2 18 46_AM

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Nov 23, 2024
Copy link

melvin-bot bot commented Nov 23, 2024

Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 23, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

Production:

Bug6673915_1732346142730.production.mp4

@gijoe0295
Copy link
Contributor

Offending PR: #52815. This prevents the teacher-unite which isOptimisticReport from being fetched from server.

Copy link

melvin-bot bot commented Nov 25, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@allgandalf
Copy link
Contributor

Most probably will be fixed by #53050 c.c. @bernhardoj

@bernhardoj
Copy link
Contributor

correct

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Nov 25, 2024
@mountiny
Copy link
Contributor

Fix CPed

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 26, 2024
@melvin-bot melvin-bot bot changed the title Save the world-The #teachers-unite is not loading after completing the "I know a teacher" flow [HOLD for payment 2024-12-03] Save the world-The #teachers-unite is not loading after completing the "I know a teacher" flow Nov 26, 2024
Copy link

melvin-bot bot commented Nov 26, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 26, 2024
Copy link

melvin-bot bot commented Nov 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-03. 🎊

For reference, here are some details about the assignees on this issue:

  • @bernhardoj requires payment through NewDot Manual Requests

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Nov 28, 2024
@melvin-bot melvin-bot bot added the Weekly KSv2 label Nov 28, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-12-03] Save the world-The #teachers-unite is not loading after completing the "I know a teacher" flow [HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] Save the world-The #teachers-unite is not loading after completing the "I know a teacher" flow Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-05. 🎊

For reference, here are some details about the assignees on this issue:

  • @bernhardoj requires payment through NewDot Manual Requests

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 3, 2024
Copy link

melvin-bot bot commented Dec 5, 2024

Issue is ready for payment but no BZ is assigned. @slafortune you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Dec 5, 2024

Payment Summary

Upwork Job

BugZero Checklist (@slafortune)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Dec 5, 2024
@slafortune
Copy link
Contributor

Reviewer: @bernhardoj owed $250 via NewDot

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants