[HOLD for payment 2024-12-16] Search - No sound when paying expense in Search

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense to the workspace.
4. Click dropdown button on the expense preview.
5. Select Pay elsewhere (do not pay it).
6. Go to Search.
7. Click Pay button.

Expected Result:

There will be sound when paying expense in Search.

Actual Result:

There is no sound when paying expense in Search.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6674090_1732364031401.20241123_201226.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - No sound when paying expense in Search

What is the root cause of that problem?

When clicking the action button on the report preview or the button in the header, we are using the playSound function to play the sound

App/src/components/SettlementButton/index.tsx

Line 217 in 3ebe852

playSound(SOUNDS.SUCCESS);

What changes do you think we should make in order to solve the problem?

We should apply the same approach to actions executed on the Search Page. The playSound function can be incorporated either after the payMoneyRequestOnSearch function. Or we can add playSound function into payMoneyRequestOnSearch.

App/src/libs/actions/Search.ts

Lines 90 to 98 in 3ebe852

	if (lastPolicyPaymentMethod === CONST.IOU.PAYMENT_TYPE.ELSEWHERE) {
	payMoneyRequestOnSearch(hash, [{reportID: item.reportID, amount, paymentType: lastPolicyPaymentMethod}], transactionID);
	return;
	}
	const hasVBBA = !!allSnapshots?.[`${ONYXKEYS.COLLECTION.SNAPSHOT}${hash}`]?.data?.[`${ONYXKEYS.COLLECTION.POLICY}${item.policyID}`]?.achAccount?.bankAccountID;
	if (hasVBBA) {
	payMoneyRequestOnSearch(hash, [{reportID: item.reportID, amount, paymentType: lastPolicyPaymentMethod}], transactionID);
	return;

What alternative solutions did you explore? (Optional)

[ishpaul777]

offending PR #52441

[allgandalf]

that is hell lot of issues linked @ishpaul777 😆

[mountiny]

I dont think this has to be a blocker, the pay action works, there is just no sound.

[luacmartins]

Yea, I'll look into this, thanks!

[melvin-bot]

@luacmartins, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

Working on it this week

[jjcoffee]

Could I get assigned here for the C+ review? Thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Play sound when paying on search #53234

If no regressions arise, payment will be issued on 2024-12-16. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment through NewDot Manual Requests

[melvin-bot]

@jjcoffee @bfitzexpensify @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @jjcoffee owed $250 via NewDot

BugZero Checklist (@bfitzexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[jjcoffee]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Show search action buttons v2 #52441 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Expensify sounds are enabled

Test:

1. Go to any workspace chat.
2. Submit an expense to the workspace.
3. Click dropdown button on the expense preview.
4. Select Pay elsewhere (do not pay it).
5. Go to Search.
6. Click Pay button.
7. Verify the a sound plays

Do we agree 👍 or 👎

[bfitzexpensify]

Payment summary:

@jjcoffee owed $250 via NewDot manual request

[garrettmknight]

$250 approved for @jjcoffee