Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room - Who can post displays All members after setting it to Admins #53002

Closed
4 of 7 tasks
IuliiaHerets opened this issue Nov 23, 2024 · 9 comments
Closed
4 of 7 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.66-0
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5257611
Issue reported by: Applause Internal Team

Action Performed:

  1. Log in to NewDot with an account that owns an existing Workspace
  2. Click on FAB/ Start Chat/ #Room.
  3. Enter room name and select a workspace.
  4. Set "Who can post" setting to "admins only"
  5. Create a room.
  6. Click on the header of created room chat/ Settings.
  7. Verify that Who can post setting is set to "Admins only".

Expected Result:

Who can post setting is set to Admins only in the room details after selecting this option during room creation process.

Actual Result:

Who can post setting is set to All members in the room details after selecting "Admins only" during room creation process.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • [x ] MacOS: Desktop

Screenshots/Videos

Bug6673892_1732342512444.Who_can_post.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 23, 2024
Copy link

melvin-bot bot commented Nov 23, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 23, 2024
Copy link

melvin-bot bot commented Nov 23, 2024

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 23, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 23, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@rojiphil
Copy link
Contributor

This is a BE issue as AddWorkspaceRoom API request returns response for writeCapability as all even when it is requested with admins.

Screenshot 2024-11-25 at 5 48 27 PM

@rlinoz rlinoz added the DeployBlocker Indicates it should block deploying the API label Nov 25, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Nov 25, 2024

Apparently this is Web-E as mentioned in the code above, still trying to find out what it is.

@rlinoz rlinoz removed the DeployBlocker Indicates it should block deploying the API label Nov 25, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Nov 25, 2024

Oh actually, apparently in prod we call OpenReport right after calling AddWorkspaceRoom which returns the correct writeCapability

@rlinoz
Copy link
Contributor

rlinoz commented Nov 25, 2024

Im gonna remove the blocker since I think we should fix the AddWorkspaceRoom response.

@rlinoz rlinoz added Daily KSv2 Reviewing Has a PR in review and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 25, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Nov 28, 2024

Deployed to prod

@rlinoz rlinoz closed this as completed Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants