Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] Expense - Workspace chat shows Not here page when it is created from "Pay with Expensify" #53013

Closed
8 tasks done
lanitochka17 opened this issue Nov 23, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • The default currency for individual policy is USD
  1. Go to staging.new.expensify.com
  2. Go to FAB > Submit expense
  3. Submit a manual expense to user B
  4. As user B, go to chat with user A
  5. Click Pay with Expensify
  6. Click Business bank account
  7. Dismiss bank account setup RHP

Expected Result:

Workspace chat will load without issue (production behavior)

Actual Result:

Workspace chat shows Not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6673972_1732352814897.20241123_170226.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @NikkiWines
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Nov 23, 2024
Copy link

melvin-bot bot commented Nov 23, 2024

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 23, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

Production:

bandicam.2024-11-23.11-29-03-020.mp4

@ishpaul777
Copy link
Contributor

I think #52815 is offending PR, checking with revert

@ishpaul777
Copy link
Contributor

ishpaul777 commented Nov 25, 2024

confirmed @bernhardoj @hoangzinh

Screen.Recording.2024-11-25.at.6.36.53.PM.mov

@NikkiWines
Copy link
Contributor

Nice, I was just looking at that one actually 😄

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Nov 25, 2024
@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Nov 25, 2024
@mountiny
Copy link
Contributor

PR cped

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 26, 2024
@melvin-bot melvin-bot bot changed the title Expense - Workspace chat shows Not here page when it is created from "Pay with Expensify" [HOLD for payment 2024-12-03] Expense - Workspace chat shows Not here page when it is created from "Pay with Expensify" Nov 26, 2024
Copy link

melvin-bot bot commented Nov 26, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 26, 2024
Copy link

melvin-bot bot commented Nov 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-03. 🎊

For reference, here are some details about the assignees on this issue:

  • @hoangzinh requires payment through NewDot Manual Requests

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 28, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-12-03] Expense - Workspace chat shows Not here page when it is created from "Pay with Expensify" [HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] Expense - Workspace chat shows Not here page when it is created from "Pay with Expensify" Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-05. 🎊

For reference, here are some details about the assignees on this issue:

  • @hoangzinh requires payment through NewDot Manual Requests

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 3, 2024
Copy link

melvin-bot bot commented Dec 5, 2024

Issue is ready for payment but no BZ is assigned. @OfstadC you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Dec 5, 2024

Payment Summary

Upwork Job

BugZero Checklist (@OfstadC)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Dec 5, 2024
@hoangzinh
Copy link
Contributor

It's a regression from our PR #53013 (comment). Therefore, there will be no payment for this issue. We can close this issue.

@OfstadC OfstadC closed this as completed Dec 5, 2024
@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants