Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure settings #481

Merged
merged 6 commits into from
May 27, 2023
Merged

Restructure settings #481

merged 6 commits into from
May 27, 2023

Conversation

fremartini
Copy link
Member

  • Move Settings to a feature
  • Move nested widgets into own files

@fremartini fremartini requested a review from a team May 27, 2023 07:38
@ghost
Copy link

ghost commented May 27, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #481 (7fa09a8) into develop (b30ed85) will increase coverage by 0.67%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #481      +/-   ##
===========================================
+ Coverage    67.85%   68.53%   +0.67%     
===========================================
  Files          101      103       +2     
  Lines         1120     1144      +24     
===========================================
+ Hits           760      784      +24     
  Misses         360      360              
Flag Coverage Δ
unittests 68.53% <ø> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/core/widgets/images/coffee_image.dart 100.00% <ø> (ø)
lib/core/widgets/list_entry.dart 100.00% <ø> (ø)

Copy link
Member

@marfavi marfavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list_entry.dart does not belong in the Settings feature. It's a generic widget that is also used by the Receipts, Occupation, Credits, and Leaderboard features.

lib/features/settings/presentation/widgets/footer.dart Outdated Show resolved Hide resolved
@fremartini fremartini requested a review from marfavi May 27, 2023 20:33
@fremartini fremartini enabled auto-merge (squash) May 27, 2023 20:34
@fremartini fremartini merged commit 3a1f57f into develop May 27, 2023
@fremartini fremartini deleted the frem/refactor_settings branch May 27, 2023 21:14
@marfavi marfavi mentioned this pull request May 28, 2023
marfavi added a commit that referenced this pull request May 30, 2023
# New features
* show status on receipts (#468)
* show timestamp on receipt list entry (#478)

# Fixes
* Fix showing raw html in error messages (#463)
* fix(tickets): Fix multiple `CoffeeCard`s sharing the same product id (#471)
* fix: Avoid type casting 204 return types from API (#479)
* fix(receipts): Remove purchase receipt view & refactor payment status display (#478)
* Added awaits for useTicket and FetchReceipts (#464)

# Code refactoring and added tests
* test(utils): Improve String.capitalize() and add tests (#472)
* Refactor and test Leaderboard (#443)
* Refactor payment (#465)
* Refactor environment logic (#469)
* refactor(settings): tidy up `settings_page.dart` (#473)
* Restructure settings (#481)
* Refactor and test login (#483)
* refactor and test voucher (#480)
* Refactor and test register (#486)
* Refactor and test products (#482)

# Chores
* chore: update Bloc packages (#475)
* chore: bump flutter required version to 3.10.2 (#476)
* Migrate to Dart 3 and Flutter 3.10.0 (#452)

# Developer related
* migrate to fpdart (#457)
* Install the CodeSee workflow (#467)
* Update README.md to show coverage on develop branch (#484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants