Refactor and test Leaderboard #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #443 +/- ##
===========================================
+ Coverage 57.23% 59.70% +2.46%
===========================================
Files 86 88 +2
Lines 933 943 +10
===========================================
+ Hits 534 563 +29
+ Misses 399 380 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
marfavi
requested changes
May 13, 2023
lib/features/leaderboard/data/datasources/leaderboard_remote_data_source.dart
Show resolved
Hide resolved
lib/features/leaderboard/presentation/pages/leaderboard_page.dart
Outdated
Show resolved
Hide resolved
lib/features/leaderboard/presentation/widgets/leaderboard_section.dart
Outdated
Show resolved
Hide resolved
test/features/leaderboard/data/datasources/leaderboard_remote_data_source_test.dart
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
fremartini
commented
May 15, 2023
fremartini
requested review from
TTA777 and
marfavi
and removed request for
TTA777
marfavi
reviewed
May 16, 2023
test/features/leaderboard/data/datasources/leaderboard_remote_data_source_test.dart
Outdated
Show resolved
Hide resolved
marfavi
requested changes
May 16, 2023
marfavi
reviewed
May 16, 2023
…data_source_test.dart Co-authored-by: Omid Marfavi <[email protected]>
Merged
marfavi
added a commit
that referenced
this pull request
May 30, 2023
# New features * show status on receipts (#468) * show timestamp on receipt list entry (#478) # Fixes * Fix showing raw html in error messages (#463) * fix(tickets): Fix multiple `CoffeeCard`s sharing the same product id (#471) * fix: Avoid type casting 204 return types from API (#479) * fix(receipts): Remove purchase receipt view & refactor payment status display (#478) * Added awaits for useTicket and FetchReceipts (#464) # Code refactoring and added tests * test(utils): Improve String.capitalize() and add tests (#472) * Refactor and test Leaderboard (#443) * Refactor payment (#465) * Refactor environment logic (#469) * refactor(settings): tidy up `settings_page.dart` (#473) * Restructure settings (#481) * Refactor and test login (#483) * refactor and test voucher (#480) * Refactor and test register (#486) * Refactor and test products (#482) # Chores * chore: update Bloc packages (#475) * chore: bump flutter required version to 3.10.2 (#476) * Migrate to Dart 3 and Flutter 3.10.0 (#452) # Developer related * migrate to fpdart (#457) * Install the CodeSee workflow (#467) * Update README.md to show coverage on develop branch (#484)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.