Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerFailure returns an unknown error occured #463

Merged
merged 2 commits into from
May 16, 2023

Conversation

TTA777
Copy link
Member

@TTA777 TTA777 commented May 16, 2023

Closes #447
Closes #450
ServerFailure returns an unknown error occured, if unable to decode response as json

@TTA777 TTA777 requested a review from fremartini May 16, 2023 14:22
fremartini
fremartini previously approved these changes May 16, 2023
@fremartini fremartini enabled auto-merge (squash) May 16, 2023 14:23
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #463 (f5db708) into develop (f3a072b) will decrease coverage by 0.26%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #463      +/-   ##
===========================================
- Coverage    57.49%   57.23%   -0.26%     
===========================================
  Files           86       86              
  Lines          934      933       -1     
===========================================
- Hits           537      534       -3     
- Misses         397      399       +2     
Flag Coverage Δ
unittests 57.23% <ø> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/core/errors/failures.dart 58.33% <ø> (-18.59%) ⬇️

@fremartini fremartini merged commit c6a06d9 into develop May 16, 2023
@fremartini fremartini deleted the fix/appShowsRawHtml branch May 16, 2023 15:06
@marfavi marfavi mentioned this pull request May 28, 2023
marfavi added a commit that referenced this pull request May 30, 2023
# New features
* show status on receipts (#468)
* show timestamp on receipt list entry (#478)

# Fixes
* Fix showing raw html in error messages (#463)
* fix(tickets): Fix multiple `CoffeeCard`s sharing the same product id (#471)
* fix: Avoid type casting 204 return types from API (#479)
* fix(receipts): Remove purchase receipt view & refactor payment status display (#478)
* Added awaits for useTicket and FetchReceipts (#464)

# Code refactoring and added tests
* test(utils): Improve String.capitalize() and add tests (#472)
* Refactor and test Leaderboard (#443)
* Refactor payment (#465)
* Refactor environment logic (#469)
* refactor(settings): tidy up `settings_page.dart` (#473)
* Restructure settings (#481)
* Refactor and test login (#483)
* refactor and test voucher (#480)
* Refactor and test register (#486)
* Refactor and test products (#482)

# Chores
* chore: update Bloc packages (#475)
* chore: bump flutter required version to 3.10.2 (#476)
* Migrate to Dart 3 and Flutter 3.10.0 (#452)

# Developer related
* migrate to fpdart (#457)
* Install the CodeSee workflow (#467)
* Update README.md to show coverage on develop branch (#484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants