Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor payment #465

Merged
merged 18 commits into from
May 23, 2023
Merged

Refactor payment #465

merged 18 commits into from
May 23, 2023

Conversation

fremartini
Copy link
Member

closes #385

@fremartini fremartini requested a review from a team May 16, 2023 16:10
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #465 (b818b09) into develop (ceebec7) will increase coverage by 6.39%.
The diff coverage is 82.92%.

❗ Current head b818b09 differs from pull request most recent head 72ff3a9. Consider uploading reports for the commit 72ff3a9 to get more accurate results

@@             Coverage Diff             @@
##           develop     #465      +/-   ##
===========================================
+ Coverage    59.70%   66.09%   +6.39%     
===========================================
  Files           89       99      +10     
  Lines          943     1106     +163     
===========================================
+ Hits           563      731     +168     
+ Misses         380      375       -5     
Flag Coverage Δ
unittests 66.09% <82.92%> (+6.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/core/external/external_url_launcher.dart 0.00% <0.00%> (ø)
...tures/purchase/domain/entities/payment_status.dart 33.33% <ø> (ø)
lib/features/user/domain/entities/role.dart 42.85% <ø> (ø)
lib/utils/firebase_analytics_event_logging.dart 0.00% <ø> (ø)
...es/purchase/data/repositories/payment_handler.dart 10.00% <10.00%> (ø)
.../purchase/data/repositories/mobilepay_service.dart 67.74% <67.74%> (ø)
...es/purchase/presentation/cubit/purchase_cubit.dart 97.72% <97.72%> (ø)
.../data/datasources/purchase_remote_data_source.dart 63.63% <100.00%> (ø)
.../purchase/data/models/initiate_purchase_model.dart 100.00% <100.00%> (ø)
...es/purchase/data/models/single_purchase_model.dart 100.00% <100.00%> (ø)
... and 8 more

@fremartini fremartini changed the title Frem/refactor payment Refactor payment May 16, 2023
Copy link
Member

@TTA777 TTA777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Minor changes requested and some considerations

lib/base/strings.dart Outdated Show resolved Hide resolved
@marfavi marfavi force-pushed the frem/refactor_payment branch from 26bfe3c to 9e9b4f8 Compare May 19, 2023 12:49
@fremartini fremartini requested a review from TTA777 May 19, 2023 15:48
@TTA777 TTA777 enabled auto-merge (squash) May 23, 2023 14:19
Copy link
Member

@TTA777 TTA777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ghost
Copy link

ghost commented May 23, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@TTA777 TTA777 merged commit aafdb56 into develop May 23, 2023
@TTA777 TTA777 deleted the frem/refactor_payment branch May 23, 2023 15:07
@marfavi marfavi mentioned this pull request May 28, 2023
marfavi added a commit that referenced this pull request May 30, 2023
# New features
* show status on receipts (#468)
* show timestamp on receipt list entry (#478)

# Fixes
* Fix showing raw html in error messages (#463)
* fix(tickets): Fix multiple `CoffeeCard`s sharing the same product id (#471)
* fix: Avoid type casting 204 return types from API (#479)
* fix(receipts): Remove purchase receipt view & refactor payment status display (#478)
* Added awaits for useTicket and FetchReceipts (#464)

# Code refactoring and added tests
* test(utils): Improve String.capitalize() and add tests (#472)
* Refactor and test Leaderboard (#443)
* Refactor payment (#465)
* Refactor environment logic (#469)
* refactor(settings): tidy up `settings_page.dart` (#473)
* Restructure settings (#481)
* Refactor and test login (#483)
* refactor and test voucher (#480)
* Refactor and test register (#486)
* Refactor and test products (#482)

# Chores
* chore: update Bloc packages (#475)
* chore: bump flutter required version to 3.10.2 (#476)
* Migrate to Dart 3 and Flutter 3.10.0 (#452)

# Developer related
* migrate to fpdart (#457)
* Install the CodeSee workflow (#467)
* Update README.md to show coverage on develop branch (#484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cover more cases for PaymentStatus in VerifyPurchase()
3 participants