-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor payment #465
Refactor payment #465
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #465 +/- ##
===========================================
+ Coverage 59.70% 66.09% +6.39%
===========================================
Files 89 99 +10
Lines 943 1106 +163
===========================================
+ Hits 563 731 +168
+ Misses 380 375 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Minor changes requested and some considerations
26bfe3c
to
9e9b4f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
# New features * show status on receipts (#468) * show timestamp on receipt list entry (#478) # Fixes * Fix showing raw html in error messages (#463) * fix(tickets): Fix multiple `CoffeeCard`s sharing the same product id (#471) * fix: Avoid type casting 204 return types from API (#479) * fix(receipts): Remove purchase receipt view & refactor payment status display (#478) * Added awaits for useTicket and FetchReceipts (#464) # Code refactoring and added tests * test(utils): Improve String.capitalize() and add tests (#472) * Refactor and test Leaderboard (#443) * Refactor payment (#465) * Refactor environment logic (#469) * refactor(settings): tidy up `settings_page.dart` (#473) * Restructure settings (#481) * Refactor and test login (#483) * refactor and test voucher (#480) * Refactor and test register (#486) * Refactor and test products (#482) # Chores * chore: update Bloc packages (#475) * chore: bump flutter required version to 3.10.2 (#476) * Migrate to Dart 3 and Flutter 3.10.0 (#452) # Developer related * migrate to fpdart (#457) * Install the CodeSee workflow (#467) * Update README.md to show coverage on develop branch (#484)
closes #385