-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
factor out listeners in electron.js to separate files #104
Comments
Is it already done or can I help?? |
@fboechats, I have started the process and factored out |
I see. Yes I'm interested in helping. |
@fboechats, thanks for your interest! If you want to go ahead and fork the repository, create a feature branch on your forked repository, make the proposed refactor and then send a pull request to our As mentioned in the README, for commits we follow the standards put forth by Conventional Commits.
Example:
FYI, for this repository, we follow the GitHubFlow and for external collaborators, that would mean to follow the GitHub fork workflow. If this is new to you, I recommend you read the info on those links. |
Sure, I will do that and work on getting more listeners separated. |
Factor out the getAppInstanceResources listener to its own file. refs graasp#104
Each listener should have its own file in
app/listeners
which is exported out throughapp/listeners/index.js
and imported inapp/electron.js
. Each listener should be a thunk, accepting arguments such asmainWindow
anddb
and returning the listening function.The text was updated successfully, but these errors were encountered: