refactor: factor out showDeleteSpace listener #129
Conversation
|
Hi @fboechats, will you be able to incorporate the changes? Thanks! |
|
Hi @fboechats, thanks for your changes! Could you please change the file name and squash all of the commits into one? With the message |
| @@ -2,7 +2,7 @@ | |||
| const { dialog } = require('electron'); | |||
| const { RESPOND_DELETE_SPACE_PROMPT_CHANNEL } = require('../config/channels'); | |||
|
|
|||
| const showDeleteSpace = mainWindow => () => { | |||
| const showDeleteSpacePrompt = mainWindow => () => { | |||
There was a problem hiding this comment.
This file should also be called showDeleteSpacePrompt for consistency.
| @@ -2,7 +2,7 @@ | |||
| const { dialog } = require('electron'); | |||
| const { RESPOND_EXPORT_SPACE_PROMPT_CHANNEL } = require('../config/channels'); | |||
|
|
|||
| const showExportSpace = mainWindow => (event, spaceTitle) => { | |||
| const showExportSpacePrompt = mainWindow => (event, spaceTitle) => { | |||
There was a problem hiding this comment.
This file should also be called showExportSpacePrompt for consistency.
| @@ -2,10 +2,10 @@ | |||
| const { dialog } = require('electron'); | |||
| const { RESPOND_LOAD_SPACE_PROMPT_CHANNEL } = require('../config/channels'); | |||
|
|
|||
| const showLoadSpace = mainWindow => (event, options) => { | |||
| const showLoadSpacePrompt = mainWindow => (event, options) => { | |||
There was a problem hiding this comment.
This file should also be called showLoadSpacePrompt for consistency.
|
Hi @fboechats, just wanted to know if you were going to be able to address these changes / rebase, otherwise I can try and make them myself in order to go forward with these PRs. Thanks! |
|
Hi @juancarlosfarah , sorry for the delay again, just did the changes you asked. |
|
@fboechats, would it be possible for you to squash all the 12 commits into one? That way the commit history stays clean. Here is how to do it in case you haven't done it before (subtitle: The hard(er) and less flexible way): https://gist.github.com/patik/b8a9dc5cd356f9f6f980#the-harder-and-less-flexible-way The commit message can then be similar to the first one: Many thanks! |
Factor out the showLoadSpacePrompt listener to its own file. refs #104
|
Hi @juancarlosfarah just squashed the commits, after we finished this I will keep the refactor |
|
Thanks @fboechats! I'm doing the merge manually in 50d2eb9 and 3b44fd7 to resolve conflicts and will close this and the other PRs. |
Factor out the showDeleteSpace listener to its own file.
refs #104