Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: factor out showLoadSpace listener #127

Closed
wants to merge 2 commits into from
Closed

refactor: factor out showLoadSpace listener #127

wants to merge 2 commits into from

Conversation

fboechats
Copy link
Contributor

Factor out the showLoadSpace listener to its own file.

refs #104

juancarlosfarah
juancarlosfarah requested changes Jul 10, 2019
View reviewed changes
Copy link
Member

@juancarlosfarah juancarlosfarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Just a very small change regarding naming. Can you change this to showLoadSpacePrompt? The handler basically shows a prompt to the user, so it's better to keep to the naming of the channel. Thanks!

@bootsa bootsa mentioned this pull request Aug 3, 2019
Closed
@juancarlosfarah
Copy link
Member

Hi @fboechats, will you be able to incorporate the changes? Thanks!

@juancarlosfarah
Copy link
Member

Hi @fboechats, thanks for your changes! Could you please squash all of the commits into one? With the message refactor: factor out showLoadSpacePrompt listener? That way your commit gets included in our CHANGELOG correctly, as it will be following conventional commit format. Sorry for the hassle. I would do it, but I don't think I can right to the branch on your repo. Thanks!

juancarlosfarah
juancarlosfarah requested changes Aug 6, 2019
View reviewed changes
public/app/listeners/showLoadSpace.js Outdated
@@ -0,0 +1,11 @@
// eslint-disable-next-line import/no-extraneous-dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fboechats, this file should be called showLoadSpacePrompt for consistency.

@juancarlosfarah
Copy link
Member

Also, just a minor request to change the name of the file.

@juancarlosfarah
Copy link
Member

Merged in in 50d2eb9 and 3b44fd7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancarlosfarah juancarlosfarah juancarlosfarah requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fboechats @juancarlosfarah