Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: factor out getSpace listener #112

Merged
merged 1 commit into from
Jun 21, 2019
Merged

refactor: factor out getSpace listener #112

merged 1 commit into from
Jun 21, 2019

Conversation

fboechats
Copy link
Contributor

Factor out the getSpace listener to its own file.

refs #104

Factor out the getSpace listener to its own file.

refs #104
@juancarlosfarah
Copy link
Member

Looking good. Thanks!

@juancarlosfarah juancarlosfarah merged commit e2a6651 into graasp:master Jun 21, 2019
@juancarlosfarah
Copy link
Member

juancarlosfarah commented Jun 21, 2019

@fboechats, actually, there was a small bit missing, which I have added on my end. In listeners/index.js you have to add your new listener.

const loadSpace = require('./loadSpace');
const saveSpace = require('./saveSpace');
const getSpace = require('./getSpace');         // <-- this was missing

module.exports = {
  loadSpace,
  saveSpace,
  getSpace,         // <-- and this was missing
};

You should try and run the desktop application locally to ensure that it's still running as expected before making a pull request. Instructions are in the README.

I have now added your fork to my remotes so I can check your branches before accepting them. My bad.

In any case, it's a minor thing, so I have gone ahead and fixed it on my repo.

@fboechats
Copy link
Contributor Author

Sure, forgot to add him in index.js. My bad, will make sure to run before the next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants