refactor: factor out getDeveloperMode listener #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factor out the getDeveloperMode listener to its own file. refs graasp#104
|
Hi @juancarlosfarah , I had to close the other one, but now it's without conflicts |
|
@fboechats, looks like we have new conflicts due to the latest changes from your other listener. Also, there is a lint failure due to |
|
@juancarlosfarah now it's has no conflicts |
|
@juancarlosfarah Do you want me to keep going or should wait for the merge so we don't get conflicts in the next pr?? |
|
@fboechats, sorry for the late reply. It looks good! Going to go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out the getDeveloperMode listener to its own file.
refs #104