perf: Make scheduler be called in 10 seconds interval if no tasks #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psprint
requested review from
alichtman,
pschmitt and
vladdoster
as code owners
|
Please rebase your branch. |
psprint
force-pushed
the
sched-calls-5-secs
branch
from
43a176d to
52adf58
Compare
|
I've rebased the branch. |
|
After having this commit in the zinit repo, I've no plugins loaded anymore. It seems to be, this again broke the wait ice, removing all wait ices let the plugins get loaded again. Also verified by reverting this commit on top of #417 (which I run locally) and starting with wait ices |
vladdoster
added a commit
that referenced
this pull request
Dec 1, 2022
This reverts commit 1681ce4.
vladdoster
added a commit
that referenced
this pull request
Dec 1, 2022
|
@psprint There needs to be a zunit test for this change so we avoid reverting it again. |
|
This doesn't seem to lower the CPU usage: |
psprint
added a commit
to psprint/.priv-zinit-fork
that referenced
this pull request
Dec 1, 2022
7 tasks
psprint
added a commit
to psprint/.priv-zinit-fork
that referenced
this pull request
Dec 1, 2022
@mustaqimM The commit was reverted. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 17, 2022
# [3.9.0](v3.8.0...v3.9.0) (2022-12-17) ### Bug Fixes * remove broken gh-r zunit test for "warp" ([#430](#430)) ([64fa4ae](64fa4ae)) ### Features * add `completions` ice ([#417](#417)) ([59975d7](59975d7)) * display version via `version` sub command ([bfb01e6](bfb01e6)) ### Performance Improvements * reduce scheduler task check to 10 second interval ([#429](#429)) ([1681ce4](1681ce4)) ### Reverts * "perf: reduce scheduler task check to 10 second interval ([#429](#429))" ([#432](#432)) ([cfd3261](cfd3261))
|
🎉 This PR is included in version 3.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
7 tasks
psprint
added a commit
to psprint/.priv-zinit-fork
that referenced
this pull request
Dec 30, 2022
psprint
pushed a commit
to psprint/.priv-zinit-fork
that referenced
this pull request
Dec 30, 2022
psprint
pushed a commit
to psprint/.priv-zinit-fork
that referenced
this pull request
Dec 30, 2022
# [3.9.0](zdharma-continuum/zinit@v3.8.0...v3.9.0) (2022-12-17) ### Bug Fixes * remove broken gh-r zunit test for "warp" ([zdharma-continuum#430](zdharma-continuum#430)) ([64fa4ae](zdharma-continuum@64fa4ae)) ### Features * add `completions` ice ([zdharma-continuum#417](zdharma-continuum#417)) ([59975d7](zdharma-continuum@59975d7)) * display version via `version` sub command ([bfb01e6](zdharma-continuum@bfb01e6)) ### Performance Improvements * reduce scheduler task check to 10 second interval ([zdharma-continuum#429](zdharma-continuum#429)) ([1681ce4](zdharma-continuum@1681ce4)) ### Reverts * "perf: reduce scheduler task check to 10 second interval ([zdharma-continuum#429](zdharma-continuum#429))" ([zdharma-continuum#432](zdharma-continuum#432)) ([cfd3261](zdharma-continuum@cfd3261))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed #409
Motivation and Context
Related Issue(s)
#409
Usage examples
How Has This Been Tested?
Types of changes
Checklist: