Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: PR #409 breaks plugins #427

Closed
1 task done
vladdoster opened this issue Nov 20, 2022 · 12 comments
Closed
1 task done

[bug]: PR #409 breaks plugins #427

vladdoster opened this issue Nov 20, 2022 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@vladdoster
Copy link
Member

What happened?

Plugin functionality breaks

Steps to reproduce

N/A

Relevant output

No response

Screenshots and recordings

No response

Operating System & Version

OS: darwin22.1.0 | Vendor: apple | Machine: arm | CPU: arm64 | Processor: arm | Hardware: arm64

Zsh version

zsh 5.9 (arm-apple-darwin22.1.0)

Terminal emulator

xterm-kitty

If using WSL on Windows, which version of WSL

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@vladdoster vladdoster added the bug Something isn't working label Nov 20, 2022
@vladdoster vladdoster self-assigned this Nov 20, 2022
@vladdoster vladdoster changed the title [bug]: #409 breaks zinit [bug]: PR #409 broke plugins Nov 20, 2022
@vladdoster vladdoster changed the title [bug]: PR #409 broke plugins [bug]: PR #409 breaks plugins Nov 20, 2022
@vladdoster
Copy link
Member Author

@psprint

@imhansai
Copy link

Yes, please check. The temporary solution is to execute
git reset --hard 1e5c0e9389680b94c0505e06f45f72331d61f041

@vladdoster
Copy link
Member Author

@imhansai, the following is a better solution git reset --hard HEAD^.

@vladdoster
Copy link
Member Author

After a bit more investigation, it breaks the wait ice.

@imhansai
Copy link

@imhansai, the following is a better solution git reset --hard HEAD^.

Yeah,return to the previous commit :)

@psprint
Copy link
Contributor

psprint commented Nov 20, 2022 via email

@vladdoster
Copy link
Member Author

@psprint You need to open a new PR.

@vladdoster
Copy link
Member Author

vladdoster commented Nov 20, 2022

@imhansai reverted commit 4938e84 for the time being

@jankatins
Copy link
Contributor

And again broken with the merge of #429

@jankatins
Copy link
Contributor

I experimented a bit:

With the broken commit:

zsh -x -l 2>&1 | grep "zsh.1: @zinit-scheduler"

~/.local/share/zinit/zinit.git on  jan-add-completions-ice (23a21d3e) [⇡]
[00:23:27] λ  0 // zsh.1: @zinit-scheduler following
0 // zsh.1: @zinit-scheduler following following
0 // zsh.1: @zinit-scheduler following following
0 // zsh.1: @zinit-scheduler following following
0 // zsh.1: @zinit-scheduler following following

(in the middle, my prompt is shown and then the scheduler lines appear until I press ^C^D)

Without the broken commit, the above doesn't show anything apart from the prompt.

Maybe that's an idea how to write a test for the scheduler?

@vladdoster
Copy link
Member Author

@jankatins Reverted in #432.

@vladdoster
Copy link
Member Author

Closing due to lack of activity.

@zdharma-continuum zdharma-continuum locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants