perf: decrease scheduler checks from every 1 second to 10 seconds #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psprint
requested review from
alichtman,
pschmitt and
vladdoster
as code owners
psprint
force-pushed
the
sched-calls-5-secs
branch
from
e45fec1 to
6eba10b
Compare
psprint
changed the title
|
I've updated the PR to check if there are any more tasks and schedule for 10s if not. |
|
Stupid question: is this running forever? If so: why? Can't it be stoped once all tasks have been run (and restarted, if there every comes in a new task)? |
|
They run forever because it's ~5 lines of code every 1 second. That's very
low overhead. More, if load'' and unload'' ices been passed, then the
background schedule calls are needed to test them.
…On Thu, 3 Nov 2022 at 11:30, Jan Katins ***@***.***> wrote:
Stupid question: is this running forever? If so: why? Can't it be stoped
once all tasks have been run (and restarted, if there every comes in a new
task)?
—
Reply to this email directly, view it on GitHub
<#409 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOE4CA6R4HMXK3Z7COM7C3WGOO4XANCNFSM6AAAAAARV57JGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Best regards,
Sebastian Gniazdowski
|
psprint
force-pushed
the
sched-calls-5-secs
branch
from
6eba10b to
ea67c6d
Compare
|
I've added short-circuit return if no tasks, so basically it's 1 line of code every 10 seconds if no tasks. |
vladdoster
requested changes
Nov 20, 2022
vladdoster
changed the title
|
This breaks the |
|
🎉 This PR is included in version 3.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
7 tasks
psprint
added a commit
to psprint/.priv-zinit-fork
that referenced
this pull request
Dec 30, 2022
…harma-continuum#409) The scheduler is called in 10 seconds intervals when no tasks are present to lower CPU usage. Co-authored-by: vladislav doster <[email protected]>
psprint
pushed a commit
to psprint/.priv-zinit-fork
that referenced
this pull request
Dec 30, 2022
…conds (zdharma-continuum#409)" This reverts commit 4938e84.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the time interval for the scheduler to check for queued tasks to ten seconds.
Motivation and Context
Lower system resource usage.
Related Issue(s)
#362
How Has This Been Tested?
Types of change
Checklist: