Switch redirect tests to httpbingo.org
#2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@falbrechtskirchinger thanks for taking care of this, too as well as #2089! It looks like some checks still fail. Did you figure out why? |
falbrechtskirchinger
force-pushed
the
fix-httpbin-redirects
branch
from
20e647e to
b0a7c49
Compare
|
@yhirose Checks are passing now. 😃 Edit: |
Redirect tests fail using httpbin.org or nghttp2.org/httpbin. The location header value contains a string representation of a Python byte string (e.g., b'http://www.google.com/'), which results in a 404 error.
falbrechtskirchinger
force-pushed
the
fix-httpbin-redirects
branch
from
b0a7c49 to
f8a746f
Compare
|
@falbrechtskirchinger thanks a lot for the great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirect tests fail using
httpbin.orgornghttp2.org/httpbin. The location header value contains a string representation of a Python byte string (e.g., b'http://www.google.com/'), which results in a 404 error.Note:
httpbingo.orgallows only a few destination URLs for the redirect, hence the change toexample.com.Related: #538