Skip to content

Commit b0a7c49

Browse files
Switch redirect tests to httpbingo.org
Redirect tests fail using httpbin.org or nghttp2.org/httpbin. The location header value contains a string representation of a Python byte string (e.g., b'http://www.google.com/'), which results in a 404 error.
1 parent ee0bee3 commit b0a7c49

File tree

1 file changed

+25
-18
lines changed

1 file changed

+25
-18
lines changed

test/test.cc

+25-18
Original file line numberDiff line numberDiff line change
@@ -1594,36 +1594,40 @@ TEST(YahooRedirectTest, Redirect_Online) {
15941594
EXPECT_EQ("https://www.yahoo.com/", res->location);
15951595
}
15961596

1597+
// Previously "nghttp2.org" "/httpbin/redirect-to"
1598+
#define REDIR_HOST "httpbingo.org"
1599+
#define REDIR_PATH "/redirect-to"
1600+
15971601
TEST(HttpsToHttpRedirectTest, Redirect_Online) {
1598-
SSLClient cli("nghttp2.org");
1602+
SSLClient cli(REDIR_HOST);
15991603
cli.set_follow_location(true);
1600-
auto res = cli.Get(
1601-
"/httpbin/redirect-to?url=http%3A%2F%2Fwww.google.com&status_code=302");
1604+
auto res =
1605+
cli.Get(REDIR_PATH "?url=http%3A%2F%2Fexample.com&status_code=302");
16021606
ASSERT_TRUE(res);
16031607
EXPECT_EQ(StatusCode::OK_200, res->status);
16041608
}
16051609

16061610
TEST(HttpsToHttpRedirectTest2, Redirect_Online) {
1607-
SSLClient cli("nghttp2.org");
1611+
SSLClient cli(REDIR_HOST);
16081612
cli.set_follow_location(true);
16091613

16101614
Params params;
1611-
params.emplace("url", "http://www.google.com");
1615+
params.emplace("url", "http://example.com");
16121616
params.emplace("status_code", "302");
16131617

1614-
auto res = cli.Get("/httpbin/redirect-to", params, Headers{});
1618+
auto res = cli.Get(REDIR_PATH, params, Headers{});
16151619
ASSERT_TRUE(res);
16161620
EXPECT_EQ(StatusCode::OK_200, res->status);
16171621
}
16181622

16191623
TEST(HttpsToHttpRedirectTest3, Redirect_Online) {
1620-
SSLClient cli("nghttp2.org");
1624+
SSLClient cli(REDIR_HOST);
16211625
cli.set_follow_location(true);
16221626

16231627
Params params;
1624-
params.emplace("url", "http://www.google.com");
1628+
params.emplace("url", "http://example.com");
16251629

1626-
auto res = cli.Get("/httpbin/redirect-to?status_code=302", params, Headers{});
1630+
auto res = cli.Get(REDIR_PATH "?status_code=302", params, Headers{});
16271631
ASSERT_TRUE(res);
16281632
EXPECT_EQ(StatusCode::OK_200, res->status);
16291633
}
@@ -6817,38 +6821,41 @@ TEST(DecodeWithChunkedEncoding, BrotliEncoding_Online) {
68176821
}
68186822
#endif
68196823

6824+
// Previously "https://nghttp2.org" "/httpbin/redirect-to"
6825+
#define REDIR_HOST "https://httpbingo.org"
6826+
#define REDIR_PATH "/redirect-to"
6827+
68206828
TEST(HttpsToHttpRedirectTest, SimpleInterface_Online) {
6821-
Client cli("https://nghttp2.org");
6829+
Client cli(REDIR_HOST);
68226830
cli.set_follow_location(true);
68236831
auto res =
6824-
cli.Get("/httpbin/"
6825-
"redirect-to?url=http%3A%2F%2Fwww.google.com&status_code=302");
6832+
cli.Get(REDIR_PATH "?url=http%3A%2F%2Fexample.com&status_code=302");
68266833

68276834
ASSERT_TRUE(res);
68286835
EXPECT_EQ(StatusCode::OK_200, res->status);
68296836
}
68306837

68316838
TEST(HttpsToHttpRedirectTest2, SimpleInterface_Online) {
6832-
Client cli("https://nghttp2.org");
6839+
Client cli(REDIR_HOST);
68336840
cli.set_follow_location(true);
68346841

68356842
Params params;
6836-
params.emplace("url", "http://www.google.com");
6843+
params.emplace("url", "http://example.com");
68376844
params.emplace("status_code", "302");
68386845

6839-
auto res = cli.Get("/httpbin/redirect-to", params, Headers{});
6846+
auto res = cli.Get(REDIR_PATH, params, Headers{});
68406847
ASSERT_TRUE(res);
68416848
EXPECT_EQ(StatusCode::OK_200, res->status);
68426849
}
68436850

68446851
TEST(HttpsToHttpRedirectTest3, SimpleInterface_Online) {
6845-
Client cli("https://nghttp2.org");
6852+
Client cli(REDIR_HOST);
68466853
cli.set_follow_location(true);
68476854

68486855
Params params;
6849-
params.emplace("url", "http://www.google.com");
6856+
params.emplace("url", "http://example.com");
68506857

6851-
auto res = cli.Get("/httpbin/redirect-to?status_code=302", params, Headers{});
6858+
auto res = cli.Get(REDIR_PATH "?status_code=302", params, Headers{});
68526859
ASSERT_TRUE(res);
68536860
EXPECT_EQ(StatusCode::OK_200, res->status);
68546861
}

0 commit comments

Comments
 (0)