Skip to content

Commit 20e647e

Browse files
Switch redirect tests to httpbingo.org
Redirect tests fail using httpbin.org or nghttp2.org/httpbin. The location header value contains a string representation of a Python byte string (e.g., b'http://www.google.com/'), which results in a 404 error.
1 parent 71ba7e7 commit 20e647e

File tree

1 file changed

+25
-18
lines changed

1 file changed

+25
-18
lines changed

test/test.cc

+25-18
Original file line numberDiff line numberDiff line change
@@ -1586,36 +1586,40 @@ TEST(YahooRedirectTest, Redirect_Online) {
15861586
EXPECT_EQ("https://www.yahoo.com/", res->location);
15871587
}
15881588

1589+
// Previously "nghttp2.org" "/httpbin/redirect-to"
1590+
#define REDIR_HOST "httpbingo.org"
1591+
#define REDIR_PATH "/redirect-to"
1592+
15891593
TEST(HttpsToHttpRedirectTest, Redirect_Online) {
1590-
SSLClient cli("nghttp2.org");
1594+
SSLClient cli(REDIR_HOST);
15911595
cli.set_follow_location(true);
1592-
auto res = cli.Get(
1593-
"/httpbin/redirect-to?url=http%3A%2F%2Fwww.google.com&status_code=302");
1596+
auto res =
1597+
cli.Get(REDIR_PATH "?url=http%3A%2F%2Fexample.com&status_code=302");
15941598
ASSERT_TRUE(res);
15951599
EXPECT_EQ(StatusCode::OK_200, res->status);
15961600
}
15971601

15981602
TEST(HttpsToHttpRedirectTest2, Redirect_Online) {
1599-
SSLClient cli("nghttp2.org");
1603+
SSLClient cli(REDIR_HOST);
16001604
cli.set_follow_location(true);
16011605

16021606
Params params;
1603-
params.emplace("url", "http://www.google.com");
1607+
params.emplace("url", "http://example.com");
16041608
params.emplace("status_code", "302");
16051609

1606-
auto res = cli.Get("/httpbin/redirect-to", params, Headers{});
1610+
auto res = cli.Get(REDIR_PATH, params, Headers{});
16071611
ASSERT_TRUE(res);
16081612
EXPECT_EQ(StatusCode::OK_200, res->status);
16091613
}
16101614

16111615
TEST(HttpsToHttpRedirectTest3, Redirect_Online) {
1612-
SSLClient cli("nghttp2.org");
1616+
SSLClient cli(REDIR_HOST);
16131617
cli.set_follow_location(true);
16141618

16151619
Params params;
1616-
params.emplace("url", "http://www.google.com");
1620+
params.emplace("url", "http://example.com");
16171621

1618-
auto res = cli.Get("/httpbin/redirect-to?status_code=302", params, Headers{});
1622+
auto res = cli.Get(REDIR_PATH "?status_code=302", params, Headers{});
16191623
ASSERT_TRUE(res);
16201624
EXPECT_EQ(StatusCode::OK_200, res->status);
16211625
}
@@ -6809,38 +6813,41 @@ TEST(DecodeWithChunkedEncoding, BrotliEncoding_Online) {
68096813
}
68106814
#endif
68116815

6816+
// Previously "https://nghttp2.org" "/httpbin/redirect-to"
6817+
#define REDIR_HOST "https://httpbingo.org"
6818+
#define REDIR_PATH "/redirect-to"
6819+
68126820
TEST(HttpsToHttpRedirectTest, SimpleInterface_Online) {
6813-
Client cli("https://nghttp2.org");
6821+
Client cli(REDIR_HOST);
68146822
cli.set_follow_location(true);
68156823
auto res =
6816-
cli.Get("/httpbin/"
6817-
"redirect-to?url=http%3A%2F%2Fwww.google.com&status_code=302");
6824+
cli.Get(REDIR_PATH "?url=http%3A%2F%2Fexample.com&status_code=302");
68186825

68196826
ASSERT_TRUE(res);
68206827
EXPECT_EQ(StatusCode::OK_200, res->status);
68216828
}
68226829

68236830
TEST(HttpsToHttpRedirectTest2, SimpleInterface_Online) {
6824-
Client cli("https://nghttp2.org");
6831+
Client cli(REDIR_HOST);
68256832
cli.set_follow_location(true);
68266833

68276834
Params params;
6828-
params.emplace("url", "http://www.google.com");
6835+
params.emplace("url", "http://example.com");
68296836
params.emplace("status_code", "302");
68306837

6831-
auto res = cli.Get("/httpbin/redirect-to", params, Headers{});
6838+
auto res = cli.Get(REDIR_PATH, params, Headers{});
68326839
ASSERT_TRUE(res);
68336840
EXPECT_EQ(StatusCode::OK_200, res->status);
68346841
}
68356842

68366843
TEST(HttpsToHttpRedirectTest3, SimpleInterface_Online) {
6837-
Client cli("https://nghttp2.org");
6844+
Client cli(REDIR_HOST);
68386845
cli.set_follow_location(true);
68396846

68406847
Params params;
6841-
params.emplace("url", "http://www.google.com");
6848+
params.emplace("url", "http://example.com");
68426849

6843-
auto res = cli.Get("/httpbin/redirect-to?status_code=302", params, Headers{});
6850+
auto res = cli.Get(REDIR_PATH "?status_code=302", params, Headers{});
68446851
ASSERT_TRUE(res);
68456852
EXPECT_EQ(StatusCode::OK_200, res->status);
68466853
}

0 commit comments

Comments
 (0)