This repository was archived by the owner on Mar 26, 2018. It is now read-only.
fix(app): fix duplicate styles and remove sourcePath for scripts in index.html #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should be two different merge requests. |
eddiemonge
added a commit
that referenced
this pull request
May 7, 2014
Fix handling of Bootstrap fonts. This correctly loads the fonts in `grunt serve` as well as `grunt serve:dist`. This should hopefully close all the PR's and issues related to Bootstrap fonts. Also removes styles being duplicated in a the output CSS file. This includes a potentially breaking change in that `root` of **cssmin** has been reverted (removed). Closes #552 Fixes #638 Fixes #645 Closes #661 Fixes #662 Partially closes #664 Fixes #665 Fixes #667
|
Please help to verify the fixes resolve the issues you have been having. You will need to test using the latest git code. Here are the instructions on how to do that:
Let me know if you have any issues by replying here or opening a new issue. |
|
Thanks, fix works for |
This was referenced May 21, 2014
Closed
jcamelis
pushed a commit
to jcamelis/generator-angular
that referenced
this pull request
Jul 15, 2014
Fix handling of Bootstrap fonts. This correctly loads the fonts in `grunt serve` as well as `grunt serve:dist`. This should hopefully close all the PR's and issues related to Bootstrap fonts. Also removes styles being duplicated in a the output CSS file. This includes a potentially breaking change in that `root` of **cssmin** has been reverted (removed). Closes yeoman#552 Fixes yeoman#638 Fixes yeoman#645 Closes yeoman#661 Fixes yeoman#662 Partially closes yeoman#664 Fixes yeoman#665 Fixes yeoman#667
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
<!-- build:js({.tmp,app}) scripts/scripts.js -->to<!-- build:js scripts/scripts.js -->, usemin and concat use paths from Gruntfile.js.Tested with and without Sass!