Skip to content
This repository was archived by the owner on Mar 26, 2018. It is now read-only.

Serve:dist broken #638

Closed
jnoelEFL opened this issue Mar 31, 2014 · 3 comments
Closed

Serve:dist broken #638

jnoelEFL opened this issue Mar 31, 2014 · 3 comments
Labels

Comments

@jnoelEFL
Copy link

Running "grunt serve:dist" task
with sass bootstrap the fonts path in main.css is not good and the builded script.js is not copied in index.html

@cebor
Copy link
Contributor

cebor commented Apr 3, 2014

While grunt build runs cssmin changes all your relative paths in your css files.

My workaround for this is comment out the root option of cssmin in Gruntfile.js:

    cssmin: {
      options: {
        //root: '<%= yeoman.app %>'
      }
    },

And be sure have the correct $icon-font-path in your main.scss, if you using Sass.

@jnoelEFL
Copy link
Author

jnoelEFL commented Apr 3, 2014

Thanks, that correct the problem with the CSS, but there is still the problem with the javascript

@eddiemonge eddiemonge added bug and removed build labels Apr 23, 2014
@eddiemonge
Copy link
Member

Please help to verify the fixes resolve the issues you have been having. You will need to test using the latest git code. Here are the instructions on how to do that:

  • cd to a testing directory, preferable an empty one

    git clone [email protected]:yeoman/generator-angular.git
    cd generator-angular
    npm link
    cd ..
    mkdir testfonts && cd $_
    yo angular
  • Test the generator with different prompts.

Let me know if you have any issues by replying here or opening a new issue.

jcamelis pushed a commit to jcamelis/generator-angular that referenced this issue Jul 15, 2014
Fix handling of Bootstrap fonts. This correctly loads the fonts in
`grunt serve` as well as `grunt serve:dist`. This should hopefully close
all the PR's and issues related to Bootstrap fonts.

Also removes styles being duplicated in a the output CSS file.

This includes a potentially breaking change in that `root` of **cssmin**
has been reverted (removed).

Closes yeoman#552
Fixes yeoman#638
Fixes yeoman#645
Closes yeoman#661
Fixes yeoman#662
Partially closes yeoman#664
Fixes yeoman#665
Fixes yeoman#667
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants