-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Broken relative URLs to Bootstrap glyphicons in vanilla app (without sass) #645
Comments
where is that absolute reference at? |
Same issue here, paths to fonts still contain the original bower_components path in the built vendor.css file. Same context:fresh app created without Sass. |
Same issue here, too. No Sass, yes Bootstrap: glyphicon not working. |
Might be linked to twbs/bootstrap#10941. |
you can deactivate the cssmin: {
options: {
//root: '<%= yeoman.app %>'
}
}, Have look at the options of |
Thanks @cebor, it works. But why is it activated first ? |
Its in since 0.8. I dont know why ... |
My cssmin block is already commented out by default in
|
@shmert: line 199-203 |
Sorry if I'm being obtuse, but I'm getting the same error as shmert's original post. Tried commenting out the root param in Gruntfile.js:
However in dist/styles/minified.css the path is still: /bower_components/bootstrap-sass-official/vendor/assets/fonts/bootstrap/glyphicons-halflings-regular.eot Not a biggie, just wondering why it works for some and not me. |
@ramonjd: Edit the |
slaps himself on the head |
Please help to verify the fixes resolve the issues you have been having. You will need to test using the latest git code. Here are the instructions on how to do that:
Let me know if you have any issues by replying here or opening a new issue. |
Seems to work here. |
commenting line thanks, @cebor |
Same as @Jamm. Thank you. |
this should be fixed in 0.9.0 |
Fix handling of Bootstrap fonts. This correctly loads the fonts in `grunt serve` as well as `grunt serve:dist`. This should hopefully close all the PR's and issues related to Bootstrap fonts. Also removes styles being duplicated in a the output CSS file. This includes a potentially breaking change in that `root` of **cssmin** has been reverted (removed). Closes yeoman#552 Fixes yeoman#638 Fixes yeoman#645 Closes yeoman#661 Fixes yeoman#662 Partially closes yeoman#664 Fixes yeoman#665 Fixes yeoman#667
This issue is still prevalent in the current generator among a LOT of file paths. This is amateur hour. This is the kind of thing that should be found before a version deployment. For those looking for a Yeoman-based generator that actually works correctly, follow the (slightly outdated) guide over @ Meanjs.org. |
@superghostmaster please open an issue if you believe this is the case but I haven't seen anything wrong related to paths. edit: nevermind i see you already did |
@eddiemonge was that #978? (For those following this issue.) |
I created a brand new yeoman app:
% yo angular:app
[?] Would you like to use Sass (with Compass)? No
[?] Would you like to include Bootstrap? Yes
Then I ran
% grunt build
The resulting build puts the bootstrap css into styles/cd367326.vendor.css
This bootstrap has an absolute reference to the glyphicons at
/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
This URL breaks with a 404 if the project is hosted in a subdirectory on the web server.
The text was updated successfully, but these errors were encountered: