Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Jetpack connection delegates to weak references #21052

Merged
merged 6 commits into from
Jul 19, 2023

Conversation

crazytonyli
Copy link
Contributor

Relates to #21050.

The changed delegate properties should be declared as weak references, considering how they are used:

fileprivate func openInstallJetpackURL() {
trackStat(.selectedInstallJetpack)
let controller = JetpackConnectionWebViewController(blog: blog)
controller.delegate = self
let navController = UINavigationController(rootViewController: controller)
present(navController, animated: true)
}

func openInstallJetpackURL() {
viewModel.track(AccountHelper.isLoggedIn ? .connect : .login)
let controller = JetpackConnectionWebViewController(blog: blog)
controller.delegate = self
navigationController?.pushViewController(controller, animated: true)
}

Regression Notes

  1. Potential unintended areas of impact
    None.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    None.

  3. What automated tests I added (or what prevented me from doing so)
    None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist: N/A

@crazytonyli crazytonyli added this to the 22.9 milestone Jul 11, 2023
@crazytonyli crazytonyli requested review from jkmassel and mokagio July 11, 2023 04:11
@crazytonyli crazytonyli self-assigned this Jul 11, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 11, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21052-22389b1
Version22.8
Bundle IDcom.jetpack.alpha
Commit22389b1
App Center Buildjetpack-installable-builds #5426
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 11, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21052-22389b1
Version22.8
Bundle IDorg.wordpress.alpha
Commit22389b1
App Center BuildWPiOS - One-Offs #6399
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@crazytonyli crazytonyli enabled auto-merge July 19, 2023 01:08
@crazytonyli crazytonyli merged commit 1851fa4 into trunk Jul 19, 2023
@crazytonyli crazytonyli deleted the weak-delegate-violation-fixes-2 branch July 19, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants