Change Jetpack connection delegates to weak references #21052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #21050.
The changed delegate properties should be declared as weak references, considering how they are used:
WordPress-iOS/WordPress/Classes/ViewRelated/Jetpack/Login/JetpackLoginViewController.swift
Lines 170 to 176 in 3d8c016
WordPress-iOS/WordPress/Classes/ViewRelated/Jetpack/Install/JetpackRemoteInstallViewController.swift
Lines 104 to 110 in 3d8c016
Regression Notes
Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
None.
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: N/A